qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2 of 3] a single vnc server surface
Date: Wed, 29 Jul 2009 16:34:09 +0200	[thread overview]
Message-ID: <4A705DE1.20704@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.0907291252510.23609@kaball-desktop>

On 07/29/09 14:09, Stefano Stabellini wrote:
> This patch removes the server surface from VncState and adds a single
> server surface to VncDisplay for all the possible clients connected.
> Each client maintains a different dirty bitmap in VncState.
> The guest surface is moved to VncDisplay as well because we don't need
> to track guest updates in more than one place.

I doubt you did any copyrect testing.  It is broken in master[1], and 
this patch breaks it even more.

cheers,
   Gerd

[1] fix sent to the list on monday.

  reply	other threads:[~2009-07-29 14:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-29 12:09 [Qemu-devel] [PATCH 2 of 3] a single vnc server surface Stefano Stabellini
2009-07-29 14:34 ` Gerd Hoffmann [this message]
2009-07-29 14:40   ` Stefano Stabellini
2009-07-29 15:02     ` Gerd Hoffmann
2009-07-29 15:05       ` Stefano Stabellini
2009-07-29 15:12         ` Gerd Hoffmann
2009-07-29 16:03   ` Stefano Stabellini
2009-07-29 16:06     ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A705DE1.20704@redhat.com \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefano.stabellini@eu.citrix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).