From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MWAEY-0005eY-8U
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 10:34:22 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MWAET-0005dB-IV
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 10:34:21 -0400
Received: from [199.232.76.173] (port=51418 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MWAET-0005d7-9e
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 10:34:17 -0400
Received: from mx2.redhat.com ([66.187.237.31]:34420)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MWAES-00054W-Mu
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 10:34:16 -0400
Message-ID: <4A705DE1.20704@redhat.com>
Date: Wed, 29 Jul 2009 16:34:09 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2 of 3] a single vnc server surface
References: <alpine.DEB.2.00.0907291252510.23609@kaball-desktop>
In-Reply-To: <alpine.DEB.2.00.0907291252510.23609@kaball-desktop>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: qemu-devel@nongnu.org

On 07/29/09 14:09, Stefano Stabellini wrote:
> This patch removes the server surface from VncState and adds a single
> server surface to VncDisplay for all the possible clients connected.
> Each client maintains a different dirty bitmap in VncState.
> The guest surface is moved to VncDisplay as well because we don't need
> to track guest updates in more than one place.

I doubt you did any copyrect testing.  It is broken in master[1], and 
this patch breaks it even more.

cheers,
   Gerd

[1] fix sent to the list on monday.