From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MWAKC-0007Zg-8f for qemu-devel@nongnu.org; Wed, 29 Jul 2009 10:40:12 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MWAK8-0007Y1-1e for qemu-devel@nongnu.org; Wed, 29 Jul 2009 10:40:11 -0400 Received: from [199.232.76.173] (port=53742 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWAK7-0007Xu-Nc for qemu-devel@nongnu.org; Wed, 29 Jul 2009 10:40:07 -0400 Received: from mx2.redhat.com ([66.187.237.31]:41434) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MWAK7-0006AG-1G for qemu-devel@nongnu.org; Wed, 29 Jul 2009 10:40:07 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n6TEe6Yu030622 for ; Wed, 29 Jul 2009 10:40:06 -0400 Message-ID: <4A706062.2080800@redhat.com> Date: Wed, 29 Jul 2009 17:44:50 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v2] make windows notice media change References: <20090729120719.GN30449@redhat.com> <20090729135057.GY30449@redhat.com> <4A705B0B.1070101@redhat.com> <20090729142115.GC30449@redhat.com> In-Reply-To: <20090729142115.GC30449@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: qemu-devel@nongnu.org On 07/29/2009 05:21 PM, Gleb Natapov wrote: > On Wed, Jul 29, 2009 at 05:22:03PM +0300, Avi Kivity wrote: > >> On 07/29/2009 04:50 PM, Gleb Natapov wrote: >> >>> @@ -2898,6 +2901,7 @@ static void ide_load(QEMUFile* f, IDEState *s) >>> >>> qemu_get_8s(f,&s->sense_key); >>> qemu_get_8s(f,&s->asc); >>> + qemu_get_8s(f,&s->cdrom_changed); >>> /* XXX: if a transfer is pending, we do not save it yet */ >>> } >>> >>> >>> >> Needs to be conditional on version, no? >> >> > I changed version check in vmload. > > Don't we usually allow loading from older versions? -- error compiling committee.c: too many arguments to function