From: Gerd Hoffmann <kraxel@redhat.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 2 of 3] a single vnc server surface
Date: Wed, 29 Jul 2009 17:02:41 +0200 [thread overview]
Message-ID: <4A706491.8040105@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.0907291535480.31281@kaball-desktop>
On 07/29/09 16:40, Stefano Stabellini wrote:
> On Wed, 29 Jul 2009, Gerd Hoffmann wrote:
>> I doubt you did any copyrect testing. It is broken in master[1], and
>> this patch breaks it even more.
>
> No I didn't: I notice that your fix wasn't applied yet but can be easily
> applied on top of this patch.
No, it can't. Well, it will apply. It will also build with the small
fixup. But the code isn't correct then.
The complete workflow of your patch was appearently designed without
copyrect in mind. The whole point of copyrect is to avoid sending
screen updates. Your patch doesn't handle that at all.
cheers,
Gerd
next prev parent reply other threads:[~2009-07-29 15:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-29 12:09 [Qemu-devel] [PATCH 2 of 3] a single vnc server surface Stefano Stabellini
2009-07-29 14:34 ` Gerd Hoffmann
2009-07-29 14:40 ` Stefano Stabellini
2009-07-29 15:02 ` Gerd Hoffmann [this message]
2009-07-29 15:05 ` Stefano Stabellini
2009-07-29 15:12 ` Gerd Hoffmann
2009-07-29 16:03 ` Stefano Stabellini
2009-07-29 16:06 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A706491.8040105@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).