From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MWB1s-0007tS-El
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 11:25:20 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MWB1n-0007nb-Nc
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 11:25:20 -0400
Received: from [199.232.76.173] (port=52582 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MWB1n-0007nG-Fv
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 11:25:15 -0400
Received: from mail-bw0-f227.google.com ([209.85.218.227]:33851)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paolo.bonzini@gmail.com>) id 1MWB1n-0008Ls-2o
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 11:25:15 -0400
Received: by bwz27 with SMTP id 27so34034bwz.34
	for <qemu-devel@nongnu.org>; Wed, 29 Jul 2009 08:25:14 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4A706975.5030804@gnu.org>
Date: Wed, 29 Jul 2009 17:23:33 +0200
From: Paolo Bonzini <bonzini@gnu.org>
MIME-Version: 1.0
References: <1248818713-11261-1-git-send-email-lcapitulino@redhat.com>	<1248818713-11261-2-git-send-email-lcapitulino@redhat.com>	<Pine.LNX.4.64.0907290236570.14932@linmac.oyster.ru>	<20090729102835.3e2b546b@doriath>
	<4A7050DB.2010207@redhat.com>
In-Reply-To: <4A7050DB.2010207@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 01/25] Introduce QEMU dictionary data type
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: jan.kiszka@siemens.com, aliguori@us.ibm.com, dlaor@redhat.com, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

On 07/29/2009 03:38 PM, Avi Kivity wrote:
> On 07/29/2009 04:28 PM, Luiz Capitulino wrote:
>>
>>>> +static void *__qemu_dict_get(const struct qemu_dict *qdict,
>>>> + const char *key, unsigned int hash)
>>> Do not violate the standard please.
>>
>> What's the problem, the '__' or the indentation?
>
> The __ prefix is reserved for system identifiers.

Single _ + uppercase is also reserved (I've seen many _FILENAME_H header 
guards).

Paolo