From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MWB1b-0007YI-UJ for qemu-devel@nongnu.org; Wed, 29 Jul 2009 11:25:03 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MWB1X-0007Ou-5D for qemu-devel@nongnu.org; Wed, 29 Jul 2009 11:25:03 -0400 Received: from [199.232.76.173] (port=52575 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWB1X-0007Od-1S for qemu-devel@nongnu.org; Wed, 29 Jul 2009 11:24:59 -0400 Received: from mx2.redhat.com ([66.187.237.31]:38251) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MWB1W-0008I0-Hu for qemu-devel@nongnu.org; Wed, 29 Jul 2009 11:24:58 -0400 Message-ID: <4A7069C2.1060307@redhat.com> Date: Wed, 29 Jul 2009 17:24:50 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1248818713-11261-1-git-send-email-lcapitulino@redhat.com> <1248818713-11261-2-git-send-email-lcapitulino@redhat.com> <20090729102835.3e2b546b@doriath> <4A7050DB.2010207@redhat.com> In-Reply-To: <4A7050DB.2010207@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 01/25] Introduce QEMU dictionary data type List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity , Luiz Capitulino Cc: jan.kiszka@siemens.com, aliguori@us.ibm.com, dlaor@redhat.com, qemu-devel On 07/29/2009 03:38 PM, Avi Kivity wrote: > On 07/29/2009 04:28 PM, Luiz Capitulino wrote: >> >>>> +static void *__qemu_dict_get(const struct qemu_dict *qdict, >>>> + const char *key, unsigned int hash) >>> Do not violate the standard please. >> >> What's the problem, the '__' or the indentation? > > The __ prefix is reserved for system identifiers. Single _ + uppercase is also reserved (I've seen many _FILENAME_H header guards). Paolo