From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MWBO3-0007JV-9P
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 11:48:15 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MWBNy-0007HM-G5
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 11:48:14 -0400
Received: from [199.232.76.173] (port=46828 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MWBNy-0007HC-5n
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 11:48:10 -0400
Received: from mx2.redhat.com ([66.187.237.31]:43625)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kwolf@redhat.com>) id 1MWBNx-0005ec-JZ
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 11:48:09 -0400
Message-ID: <4A706EF0.30401@redhat.com>
Date: Wed, 29 Jul 2009 17:46:56 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] add --accel option
References: <1248814081-7860-1-git-send-email-glommer@redhat.com>
	<4A70055C.3050403@redhat.com>
	<20090729154635.GD4776@poweredge.glommer>
In-Reply-To: <20090729154635.GD4776@poweredge.glommer>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

Glauber Costa schrieb:
> On Wed, Jul 29, 2009 at 10:16:28AM +0200, Kevin Wolf wrote:
>> Glauber Costa schrieb:
>>> Since libvirt dudes seem to prefer it, add a --accel option. For now,
>>> it only does the same as --enable-kvm, but it can easily be extended
>>> in the future. It also accepts "none" and "kqemu" options.
>> The documentation should include which values are valid for the option.
>> Guessing that the syntax is -accel kvm is probably possible, but for
>> -accel kqemu,mode=kernel it's definitely hard.
> right now kqemu needs an extra argument.
> 
> But very soon kvm will need it too. Like for example controlling knobs
> like kvm-irqchip and kvm-pit. So maybe we want a standard way of passing
> arguments for all accels?
> 
> How about --accel foo,args=bar,bar,bar with the args part being optional ?
> 
> An exampel would be --accel kvm,args=userpit,userirqchip (assuming we want the
> default to be in the kernel)

Why not the usual -accel kvm,userpit=on and so on? When having such
parameters you probably should be using QemuOpts/qemu-option in the end
anyway.

But actually I was just arguing that the parameters need to be
documented, whatever they look like.

Kevin