From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MWBXF-0002JC-4A
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 11:57:45 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MWBX9-0002HR-Vu
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 11:57:44 -0400
Received: from [199.232.76.173] (port=39479 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MWBX9-0002HN-TZ
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 11:57:39 -0400
Received: from mx2.redhat.com ([66.187.237.31]:48367)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kwolf@redhat.com>) id 1MWBX9-0007yp-6v
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 11:57:39 -0400
Message-ID: <4A70712A.2070902@redhat.com>
Date: Wed, 29 Jul 2009 17:56:26 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1248814081-7860-1-git-send-email-glommer@redhat.com>	<4A70055C.3050403@redhat.com>	<20090729154635.GD4776@poweredge.glommer>
	<m363db5vzj.fsf@neno.mitica>
In-Reply-To: <m363db5vzj.fsf@neno.mitica>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] add --accel option
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@trasno.org>
Cc: Glauber Costa <glommer@redhat.com>, aliguori@us.ibm.com, qemu-devel@nongnu.org

Juan Quintela schrieb:
> Glauber Costa <glommer@redhat.com> wrote:
>> On Wed, Jul 29, 2009 at 10:16:28AM +0200, Kevin Wolf wrote:
>>> Glauber Costa schrieb:
>>>> Since libvirt dudes seem to prefer it, add a --accel option. For now,
>>>> it only does the same as --enable-kvm, but it can easily be extended
>>>> in the future. It also accepts "none" and "kqemu" options.
>>> The documentation should include which values are valid for the option.
>>> Guessing that the syntax is -accel kvm is probably possible, but for
>>> -accel kqemu,mode=kernel it's definitely hard.
>> right now kqemu needs an extra argument.
>>
>> But very soon kvm will need it too. Like for example controlling knobs
>> like kvm-irqchip and kvm-pit. So maybe we want a standard way of passing
>> arguments for all accels?
>>
>> How about --accel foo,args=bar,bar,bar with the args part being optional ?
>>
>> An exampel would be --accel kvm,args=userpit,userirqchip (assuming we want the
>> default to be in the kernel)
>>
>> Otherwise we're stuck with an evergrowing combination to support
> 
> No, pleaseeee
> "," shouldn't have two meanings in the same command line
> 
> --accel kvm,userpit,userirqchip
> 
> is ok
> 
> --accell kvm,userpit=on,userirqchip=off
> 
> also ok

QemuOpts supports both of these (and none of the versions below).

Kevin


> 
> --accell kvm,args=userpit,userirqchip
> 
> parses as
>    args=userpit
>    userirqchip
> or
>    args=userpit,userirqchip
> 
> IMHO, having lists inside lists is just insane, and if you want it, do
> it marking the list properly:
> 
> --accell kvm,args=[userpit,userirqchip]
> 
> or any other opening/closing pair.
> 
> Later, Juan.