From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MWBny-00033n-6E for qemu-devel@nongnu.org; Wed, 29 Jul 2009 12:15:02 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MWBns-00031B-Av for qemu-devel@nongnu.org; Wed, 29 Jul 2009 12:15:00 -0400 Received: from [199.232.76.173] (port=46639 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWBns-000316-6R for qemu-devel@nongnu.org; Wed, 29 Jul 2009 12:14:56 -0400 Received: from mx2.redhat.com ([66.187.237.31]:47928) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MWBnr-0004R8-JH for qemu-devel@nongnu.org; Wed, 29 Jul 2009 12:14:55 -0400 Message-ID: <4A70769A.7000404@redhat.com> Date: Wed, 29 Jul 2009 19:19:38 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1248818713-11261-1-git-send-email-lcapitulino@redhat.com> <1248818713-11261-2-git-send-email-lcapitulino@redhat.com> <4A701AA3.4060902@redhat.com> <20090729104600.17deb355@doriath> <4A705536.3020305@redhat.com> <20090729112220.16ffe414@doriath> <4A705EAB.1030200@redhat.com> <20090729131131.2d5e4fa6@doriath> In-Reply-To: <20090729131131.2d5e4fa6@doriath> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 01/25] Introduce QEMU dictionary data type List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: jan.kiszka@siemens.com, aliguori@us.ibm.com, dlaor@redhat.com, qemu-devel@nongnu.org On 07/29/2009 07:11 PM, Luiz Capitulino wrote: > Btw, the patches that ports command handlers have some void * to > long type conversions (eg. patch 14) can someone please review > them? > > I'm not 100% confident about them. > Casting long to void * may lose precision on some hosts (Windows x64). Much better off casting the void * to a long * and dereferencing (and deallocating later). -- error compiling committee.c: too many arguments to function