From: Anthony Liguori <anthony@codemonkey.ws>
To: Jordan Justen <jljusten@gmail.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] Re: [PATCH 2/2] Make sure to enable dirty log tracking for VMware VGA
Date: Wed, 29 Jul 2009 12:15:19 -0500 [thread overview]
Message-ID: <4A7083A7.3050007@codemonkey.ws> (raw)
In-Reply-To: <2a50f7880907290923s4568986cs7548650c9315cdf0@mail.gmail.com>
Jordan Justen wrote:
> On Mon, Jun 8, 2009 at 2:53 PM, Anthony Liguori<aliguori@us.ibm.com> wrote:
>
>> Anthony Liguori wrote:
>>
>>> This is needed for VMware VGA to work properly under KVM.
>>>
>>> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>>> ---
>>> hw/vmware_vga.c | 4 ++++
>>> 1 files changed, 4 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c
>>> index bb17698..246011b 100644
>>> --- a/hw/vmware_vga.c
>>> +++ b/hw/vmware_vga.c
>>> @@ -1203,6 +1203,10 @@ static void pci_vmsvga_map_mem(PCIDevice *pci_dev,
>>> int region_num,
>>> #endif
>>> cpu_register_physical_memory(s->vram_base, s->vga.vram_size,
>>> iomemtype);
>>> +
>>> + s->vga.map_addr = addr;
>>> + s->vga.map_end = addr + s->vga.vram_size;
>>> + vga_dirty_log_start(&s->vga);
>>> }
>>>
>>> void pci_vmsvga_init(PCIBus *bus)
>>>
>>>
>> N.B. depth is still screwed up with VMware vga but the fix for that looks a
>> bit more non-obvious. This VBE issue has been a long standing problem
>> though and I suspect it effects other guests though.
>>
>>
>
> I've tried booting Ubuntu 8.10/9.04 using '-vga vmware' on various versions of
> kvm and qemu. The result is always ok video during BIOS post, but garbage
> during pre and post X. Would this be a symptom of the 'VBE' issue that
> you mentioned?
>
Try the latest qemu git. vmware vga should work there.
I'm not sure about qemu-kvm. It depends on whether the changes survived
the merge.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-07-29 17:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-08 21:48 [Qemu-devel] [PATCH 1/2] Make sure to enable dirty tracking of VBE vram mapping Anthony Liguori
2009-06-08 21:48 ` [Qemu-devel] [PATCH 2/2] Make sure to enable dirty log tracking for VMware VGA Anthony Liguori
2009-06-08 21:53 ` [Qemu-devel] " Anthony Liguori
2009-07-29 16:23 ` Jordan Justen
2009-07-29 17:15 ` Anthony Liguori [this message]
2009-07-29 17:56 ` Jordan Justen
2009-07-29 18:47 ` Anthony Liguori
[not found] ` <loom.20090609T011827-203@post.gmane.org>
2009-06-09 3:37 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A7083A7.3050007@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=aliguori@us.ibm.com \
--cc=jljusten@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).