From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MWCkT-00013d-Td for qemu-devel@nongnu.org; Wed, 29 Jul 2009 13:15:30 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MWCkP-0000ws-2A for qemu-devel@nongnu.org; Wed, 29 Jul 2009 13:15:29 -0400 Received: from [199.232.76.173] (port=43893 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWCkO-0000wZ-Sp for qemu-devel@nongnu.org; Wed, 29 Jul 2009 13:15:24 -0400 Received: from qw-out-1920.google.com ([74.125.92.149]:42270) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MWCkO-0007zN-Iw for qemu-devel@nongnu.org; Wed, 29 Jul 2009 13:15:24 -0400 Received: by qw-out-1920.google.com with SMTP id 5so470028qwc.4 for ; Wed, 29 Jul 2009 10:15:22 -0700 (PDT) Message-ID: <4A7083A7.3050007@codemonkey.ws> Date: Wed, 29 Jul 2009 12:15:19 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 2/2] Make sure to enable dirty log tracking for VMware VGA References: <1244497683-14391-1-git-send-email-aliguori@us.ibm.com> <1244497683-14391-2-git-send-email-aliguori@us.ibm.com> <4A2D886C.5020007@us.ibm.com> <2a50f7880907290923s4568986cs7548650c9315cdf0@mail.gmail.com> In-Reply-To: <2a50f7880907290923s4568986cs7548650c9315cdf0@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jordan Justen Cc: Anthony Liguori , qemu-devel@nongnu.org, kvm@vger.kernel.org Jordan Justen wrote: > On Mon, Jun 8, 2009 at 2:53 PM, Anthony Liguori wrote: > >> Anthony Liguori wrote: >> >>> This is needed for VMware VGA to work properly under KVM. >>> >>> Signed-off-by: Anthony Liguori >>> --- >>> hw/vmware_vga.c | 4 ++++ >>> 1 files changed, 4 insertions(+), 0 deletions(-) >>> >>> diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c >>> index bb17698..246011b 100644 >>> --- a/hw/vmware_vga.c >>> +++ b/hw/vmware_vga.c >>> @@ -1203,6 +1203,10 @@ static void pci_vmsvga_map_mem(PCIDevice *pci_dev, >>> int region_num, >>> #endif >>> cpu_register_physical_memory(s->vram_base, s->vga.vram_size, >>> iomemtype); >>> + >>> + s->vga.map_addr = addr; >>> + s->vga.map_end = addr + s->vga.vram_size; >>> + vga_dirty_log_start(&s->vga); >>> } >>> >>> void pci_vmsvga_init(PCIBus *bus) >>> >>> >> N.B. depth is still screwed up with VMware vga but the fix for that looks a >> bit more non-obvious. This VBE issue has been a long standing problem >> though and I suspect it effects other guests though. >> >> > > I've tried booting Ubuntu 8.10/9.04 using '-vga vmware' on various versions of > kvm and qemu. The result is always ok video during BIOS post, but garbage > during pre and post X. Would this be a symptom of the 'VBE' issue that > you mentioned? > Try the latest qemu git. vmware vga should work there. I'm not sure about qemu-kvm. It depends on whether the changes survived the merge. Regards, Anthony Liguori