From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MWEu2-0002xz-Tb
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 15:33:31 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MWEty-0002rx-4j
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 15:33:30 -0400
Received: from [199.232.76.173] (port=56221 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MWEtx-0002rW-Oq
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 15:33:25 -0400
Received: from qw-out-1920.google.com ([74.125.92.148]:29158)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MWEtx-0007AH-Ix
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 15:33:25 -0400
Received: by qw-out-1920.google.com with SMTP id 5so525983qwc.4
	for <qemu-devel@nongnu.org>; Wed, 29 Jul 2009 12:33:24 -0700 (PDT)
Message-ID: <4A70A400.2070703@codemonkey.ws>
Date: Wed, 29 Jul 2009 14:33:20 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2] make windows notice media change
References: <20090729120719.GN30449@redhat.com>	<20090729135057.GY30449@redhat.com>
	<5b31733c0907290735u5dd86d86i293f34df4ce09d10@mail.gmail.com>
In-Reply-To: <5b31733c0907290735u5dd86d86i293f34df4ce09d10@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Filip Navara <filip.navara@gmail.com>
Cc: qemu-devel@nongnu.org, Gleb Natapov <gleb@redhat.com>

Filip Navara wrote:
> On Wed, Jul 29, 2009 at 3:50 PM, Gleb Natapov<gleb@redhat.com> wrote:
> [snip]
>   
>> @@ -2898,6 +2901,7 @@ static void ide_load(QEMUFile* f, IDEState *s)
>>
>>     qemu_get_8s(f, &s->sense_key);
>>     qemu_get_8s(f, &s->asc);
>> +    qemu_get_8s(f, &s->cdrom_changed);
>>     /* XXX: if a transfer is pending, we do not save it yet */
>>  }
>>
>> @@ -3219,7 +3223,7 @@ static int pci_ide_load(QEMUFile* f, void *opaque, int version_id)
>>     PCIIDEState *d = opaque;
>>     int ret, i;
>>
>> -    if (version_id != 2)
>> +    if (version_id != 3)
>>         return -EINVAL;
>>     ret = pci_device_load(&d->dev, f);
>>     if (ret < 0)
>>     
>
> Why shouldn't we support loading version 2 snapshots? Afterall that's
> why we had the versioning in the first place.
>   

What value do you give cdrom_changed?

If you give it zero, and you happened to be in a state where the cdrom 
was in the process of being changed when you migrated, this bug would 
surface again.

In this case, it's better to refuse the old (broken) version.

Regards,

Anthony Liguori