From: Paolo Bonzini <bonzini@gnu.org>
To: Juan Quintela <quintela@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 30/42] Rename CPPFLAGS to CFLAGS
Date: Thu, 30 Jul 2009 08:58:46 +0200 [thread overview]
Message-ID: <4A7144A6.5060704@gnu.org> (raw)
In-Reply-To: <ab3233d773b11a0c044a270d09e6e5ad261c13f9.1248918837.git.quintela@redhat.com>
Just wanted to point out that this is wrong. -I and -D *are* CPPFLAGS.
However, the real issue is that CFLAGS should be reserved for the user
at make time (defaulting to something *constant* like -O2 -g or whatever
else). Actually so should CPPFLAGS, but at least it is much less likely
to be used, while "make CFLAGS=-g" is common during development and
supported by almost every package I know of.
You can also call it QEMU_CPPFLAGS or QEMU_CFLAGS and we can be happy.
You then have to add both $(QEMU_CPPFLAGS) and $(CFLAGS) to compilation
commands in both configure and Make.
Paolo
next prev parent reply other threads:[~2009-07-30 6:58 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-30 2:06 [Qemu-devel] [PATCH 00/42] More Makefile/configure simplification Juan Quintela
2009-07-30 2:06 ` [Qemu-devel] [PATCH 01/42] strip binary is not used anywhere Juan Quintela
2009-07-30 2:06 ` [Qemu-devel] [PATCH 02/42] oss variable don't exist anymore Juan Quintela
2009-07-30 2:06 ` [Qemu-devel] [PATCH 03/42] Use CFLAGS from enviroment, ARCH_CFLAGS hasn't been defined yet Juan Quintela
2009-07-30 2:06 ` [Qemu-devel] [PATCH 04/42] move cpu command line setting to the beggining Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 05/42] move check_linker_flags sooner than starting of printing variables Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 06/42] remove not needed rt variable Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 07/42] move checks for bswap32/bswap_32 sooner than starting of printing variables Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 08/42] move general CFLAGS/LDFLAGS definitions after last $cc run Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 09/42] We want to add options at the beggining, not at the end of variables Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 10/42] Remove OS_{CFLAGS, LDFLAGS} and ARCH_{LDFLAGS, CFLAGS} Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 11/42] move EXTRA_CFLAGS/LDFLAGS to the very beginning Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 12/42] create compile_object/compile_prog functions Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 13/42] remove unused temporal files Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 14/42] Add CURL_CFLAGS Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 15/42] __sparc_*__ is defined through -D__sparc_*__ Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 16/42] move mingw32 code after selection of OS Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 17/42] This variables can't be set here Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 18/42] refactor kqemu selection for both mingw32 Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 19/42] move sparc_cpu arg parsing to the begining Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 20/42] refactor sparc_cpu code to be in a single place Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 21/42] refactor $cpu selection in various places Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 22/42] reindent Operating System selection configure Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 23/42] We use -lz for all binaries Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 24/42] We want to pass LIB through configuration files now Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 25/42] PTHREADLIBS was used for all binaries Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 26/42] CLOCKLIBS " Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 27/42] Move to configure CONFIG_SOLARIS libraries needed always Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 28/42] Move to configure CONFIG_WIN32 " Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 29/42] We set -Werror through configure now Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 30/42] Rename CPPFLAGS to CFLAGS Juan Quintela
2009-07-30 6:58 ` Paolo Bonzini [this message]
2009-07-30 7:16 ` [Qemu-devel] " Juan Quintela
2009-07-30 9:25 ` Paolo Bonzini
2009-07-30 9:40 ` Juan Quintela
2009-07-30 9:45 ` Paolo Bonzini
2009-07-30 9:54 ` Juan Quintela
2009-07-30 16:07 ` Jamie Lokier
2009-07-30 16:24 ` Juan Quintela
2009-07-30 10:27 ` malc
2009-07-30 2:07 ` [Qemu-devel] [PATCH 31/42] split CFLAGS very long line Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 32/42] move common CFLAGS to configure Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 33/42] Refactor HELPER_CFLAGS Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 34/42] move SDL_LIBS Win32 hack to configure Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 35/42] Add libs_softmmu variable Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 36/42] Add SDL_LIBS to libs_softmmu Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 37/42] gcc generates the right dependency for this file Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 38/42] move coreaudio libraries to coreaudio selection Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 39/42] Move sound library selection to sound selection Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 40/42] files are only compiled when CONFIG_ADLIB is defined Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 41/42] Test if we need -lutil in ,/configure Juan Quintela
2009-07-30 2:07 ` [Qemu-devel] [PATCH 42/42] Fold CURSES_LIBS into libsoftmmu_libs Juan Quintela
2009-07-30 3:43 ` andrzej zaborowski
2009-07-30 7:14 ` [Qemu-devel] " Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A7144A6.5060704@gnu.org \
--to=bonzini@gnu.org \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).