From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MWPbN-0002Y1-6p
	for qemu-devel@nongnu.org; Thu, 30 Jul 2009 02:58:57 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MWPbI-0002Xp-Ff
	for qemu-devel@nongnu.org; Thu, 30 Jul 2009 02:58:56 -0400
Received: from [199.232.76.173] (port=51095 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MWPbI-0002Xm-A9
	for qemu-devel@nongnu.org; Thu, 30 Jul 2009 02:58:52 -0400
Received: from mx20.gnu.org ([199.232.41.8]:9981)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paolo.bonzini@gmail.com>)
	id 1MWPbG-0000Qs-V0
	for qemu-devel@nongnu.org; Thu, 30 Jul 2009 02:58:51 -0400
Received: from mail-fx0-f207.google.com ([209.85.220.207])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paolo.bonzini@gmail.com>) id 1MWPbF-0004TX-BR
	for qemu-devel@nongnu.org; Thu, 30 Jul 2009 02:58:49 -0400
Received: by fxm3 with SMTP id 3so753252fxm.8
	for <qemu-devel@nongnu.org>; Wed, 29 Jul 2009 23:58:48 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4A7144A6.5060704@gnu.org>
Date: Thu, 30 Jul 2009 08:58:46 +0200
From: Paolo Bonzini <bonzini@gnu.org>
MIME-Version: 1.0
References: <cover.1248918836.git.quintela@redhat.com>
	<ab3233d773b11a0c044a270d09e6e5ad261c13f9.1248918837.git.quintela@redhat.com>
In-Reply-To: <ab3233d773b11a0c044a270d09e6e5ad261c13f9.1248918837.git.quintela@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 30/42] Rename CPPFLAGS to CFLAGS
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

Just wanted to point out that this is wrong.  -I and -D *are* CPPFLAGS.

However, the real issue is that CFLAGS should be reserved for the user 
at make time (defaulting to something *constant* like -O2 -g or whatever 
else).  Actually so should CPPFLAGS, but at least it is much less likely 
to be used, while "make CFLAGS=-g" is common during development and 
supported by almost every package I know of.

You can also call it QEMU_CPPFLAGS or QEMU_CFLAGS and we can be happy.
You then have to add both $(QEMU_CPPFLAGS) and $(CFLAGS) to compilation 
commands in both configure and Make.

Paolo