From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MWSCy-000555-4h
	for qemu-devel@nongnu.org; Thu, 30 Jul 2009 05:45:56 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MWSCt-00051g-8y
	for qemu-devel@nongnu.org; Thu, 30 Jul 2009 05:45:55 -0400
Received: from [199.232.76.173] (port=55014 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MWSCt-00051Q-0L
	for qemu-devel@nongnu.org; Thu, 30 Jul 2009 05:45:51 -0400
Received: from ey-out-1920.google.com ([74.125.78.148]:16308)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paolo.bonzini@gmail.com>) id 1MWSCs-0003AX-9m
	for qemu-devel@nongnu.org; Thu, 30 Jul 2009 05:45:50 -0400
Received: by ey-out-1920.google.com with SMTP id 5so281980eyb.4
	for <qemu-devel@nongnu.org>; Thu, 30 Jul 2009 02:45:49 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4A716BCA.4050304@gnu.org>
Date: Thu, 30 Jul 2009 11:45:46 +0200
From: Paolo Bonzini <bonzini@gnu.org>
MIME-Version: 1.0
References: <cover.1248918836.git.quintela@redhat.com>	<ab3233d773b11a0c044a270d09e6e5ad261c13f9.1248918837.git.quintela@redhat.com>	<4A7144A6.5060704@gnu.org>
	<m38wi61vys.fsf@neno.mitica>	<4A7166FA.9070401@gnu.org>
	<m3prbizey9.fsf@neno.mitica>
In-Reply-To: <m3prbizey9.fsf@neno.mitica>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 30/42] Rename CPPFLAGS to CFLAGS
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org


> Ok, and what are that options?
> Looking at today Makefiles, the only things that I see that the user
> could want changing is:
>   -g
>   -O2
>   -fno-strict-aliasing
>   -fno-unit-at-a-time (ppc)
>   -msmall-data (alpha)
>   -mno-sdata (ia64)
>
> Rest of things are -I/-D stuff, that you don't want to touch from the
> command line at all.
>
> Anything else?  Should that be enough?

I'd say only "-g -O2".

-f and -m options should be left in QEMU_CFLAGS but CFLAGS should be 
expanded *after* it so that people can add 
-fstrict-aliasing/-funit-at-a-time/-mlarge-data/-msdata if they want to 
enable those options explicitly.

The rationale is that probably "make CFLAGS=-g" would break the build on 
PPC, Alpha, and IA64; and "make CFLAGS='-O3 -g'" would break the build 
everywhere due to the lack of -fno-strict-aliasing.

Paolo