From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MWUeS-0000zC-Ki
	for qemu-devel@nongnu.org; Thu, 30 Jul 2009 08:22:28 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MWUeN-0000rq-Mu
	for qemu-devel@nongnu.org; Thu, 30 Jul 2009 08:22:27 -0400
Received: from [199.232.76.173] (port=38551 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MWUeN-0000rX-GI
	for qemu-devel@nongnu.org; Thu, 30 Jul 2009 08:22:23 -0400
Received: from mx2.redhat.com ([66.187.237.31]:53747)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MWUeN-0001ft-1R
	for qemu-devel@nongnu.org; Thu, 30 Jul 2009 08:22:23 -0400
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n6UCMM4s005536
	for <qemu-devel@nongnu.org>; Thu, 30 Jul 2009 08:22:22 -0400
Message-ID: <4A719078.6020003@redhat.com>
Date: Thu, 30 Jul 2009 14:22:16 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/2] Remove the virtio-{blk, console}-pci-0-10
	device types
References: <1248949753-13269-1-git-send-email-markmc@redhat.com>
	<1248949753-13269-3-git-send-email-markmc@redhat.com>
In-Reply-To: <1248949753-13269-3-git-send-email-markmc@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mark McLoughlin <markmc@redhat.com>
Cc: qemu-devel@nongnu.org

On 07/30/09 12:29, Mark McLoughlin wrote:
> These are now unused.
>
> However, perhaps the idea is that when we add -device, they will be
> useful? In that case, we should add virtio-net-pci-0-10 too.

With -device you can switch devices into compat mode by simply setting 
the attribute.  Doesn't work (yet) because you can't create functional 
virtio console+block devices via -device right now.  I'll plan to have 
that fixed at least for virtio blk soon though.  For virtio-net this can 
be done today (-net nic,model=virtio,vectors=0 turns off msi).

So IMHO there is no need in keeping the device types and the patch 
should be applied.

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

cheers,
   Gerd