qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Naphtali Sprei <nsprei@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] call ide_reset when resetting the piix
Date: Thu, 30 Jul 2009 08:24:47 -0500	[thread overview]
Message-ID: <4A719F1F.40904@codemonkey.ws> (raw)
In-Reply-To: <4A6DD8F0.5060606@redhat.com>

Naphtali Sprei wrote:
> In some cases reboot sequence fails to detect the ide device in the rombios
> sequence for ata_detect, since ioport writes are ignored when the
> ide device status indicates busy or data request in progres.
> The ide if must be reset when system reset.
>
> Signed-off-by: Naphtali Sprei <nsprei@redhat.com>
>   

What is this against?

> -    qemu_register_reset(piix3_reset, 0, d);
> -    piix3_reset(d);
> -
>   

qemu_register_reset hasn't had this signature in a long time.  I think 
you need to rebase against tip.

Regards,

Anthony Liguori

  parent reply	other threads:[~2009-07-30 13:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-27 16:42 [Qemu-devel] [PATCH] call ide_reset when resetting the piix Naphtali Sprei
2009-07-27 17:17 ` Ryan Harper
2009-07-28 10:50   ` Naphtali Sprei
2009-07-30 13:24 ` Anthony Liguori [this message]
2009-08-02 15:29   ` Naphtali Sprei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A719F1F.40904@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=nsprei@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).