From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MWVcv-0006GA-BC for qemu-devel@nongnu.org; Thu, 30 Jul 2009 09:24:58 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MWVcq-0006CC-7p for qemu-devel@nongnu.org; Thu, 30 Jul 2009 09:24:56 -0400 Received: from [199.232.76.173] (port=37683 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWVcq-0006Bx-3l for qemu-devel@nongnu.org; Thu, 30 Jul 2009 09:24:52 -0400 Received: from qw-out-1920.google.com ([74.125.92.144]:17001) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MWVcp-0007Ch-5t for qemu-devel@nongnu.org; Thu, 30 Jul 2009 09:24:51 -0400 Received: by qw-out-1920.google.com with SMTP id 5so724292qwc.4 for ; Thu, 30 Jul 2009 06:24:49 -0700 (PDT) Message-ID: <4A719F1F.40904@codemonkey.ws> Date: Thu, 30 Jul 2009 08:24:47 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] call ide_reset when resetting the piix References: <4A6DD8F0.5060606@redhat.com> In-Reply-To: <4A6DD8F0.5060606@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Naphtali Sprei Cc: qemu-devel@nongnu.org Naphtali Sprei wrote: > In some cases reboot sequence fails to detect the ide device in the rombios > sequence for ata_detect, since ioport writes are ignored when the > ide device status indicates busy or data request in progres. > The ide if must be reset when system reset. > > Signed-off-by: Naphtali Sprei > What is this against? > - qemu_register_reset(piix3_reset, 0, d); > - piix3_reset(d); > - > qemu_register_reset hasn't had this signature in a long time. I think you need to rebase against tip. Regards, Anthony Liguori