From: Gerd Hoffmann <kraxel@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/5] QemuOpts: add -drive-set option
Date: Thu, 30 Jul 2009 16:35:08 +0200 [thread overview]
Message-ID: <4A71AF9C.7020500@redhat.com> (raw)
In-Reply-To: <4A71A71E.3030101@codemonkey.ws>
On 07/30/09 15:58, Anthony Liguori wrote:
> Gerd Hoffmann wrote:
>> The typical use case will be file (no filename quoting issues), i.e.
>>
>> -drive id=test,if=virtio
>> -drive-set test.file=/vmdisk/test-virtio.img
>
> I'm not a big fan of this syntax because you still end up with not
> putting a filename as a single argument.
You can take everything after '=' as-is though, so the parsing/quoting
issues are gone nevertheless.
> I don't think it extends very
> well to other option types either like -net.
Problem with the "-drive.$id.$arg $value" syntax suggested by you is
that the qemu option parser can handle fixed -option strings only.
Other ideas?
cheers,
Gerd
next prev parent reply other threads:[~2009-07-30 14:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-30 10:43 [Qemu-devel] [PATCH 0/5] QemuOpts patches Gerd Hoffmann
2009-07-30 10:43 ` [Qemu-devel] [PATCH 1/5] QemuOpts: add some functions Gerd Hoffmann
2009-07-30 10:43 ` [Qemu-devel] [PATCH 2/5] QemuOpts: qemu_opts_parse: fix id= parsing Gerd Hoffmann
2009-07-30 10:43 ` [Qemu-devel] [PATCH 3/5] QemuOpts: make the drive id actually show up in "info block" Gerd Hoffmann
2009-07-30 10:43 ` [Qemu-devel] [PATCH 4/5] QemuOpts: add -drive-set option Gerd Hoffmann
2009-07-30 13:58 ` Anthony Liguori
2009-07-30 14:35 ` Gerd Hoffmann [this message]
2009-07-30 18:44 ` Anthony Liguori
2009-07-30 10:43 ` [Qemu-devel] [PATCH 5/5] QemuOpts: switch over -device Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A71AF9C.7020500@redhat.com \
--to=kraxel@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).