From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MWWj2-0004nb-W5
	for qemu-devel@nongnu.org; Thu, 30 Jul 2009 10:35:21 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MWWiw-0004mo-Sw
	for qemu-devel@nongnu.org; Thu, 30 Jul 2009 10:35:19 -0400
Received: from [199.232.76.173] (port=49178 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MWWiw-0004me-NF
	for qemu-devel@nongnu.org; Thu, 30 Jul 2009 10:35:14 -0400
Received: from mx2.redhat.com ([66.187.237.31]:47184)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MWWiw-00059u-5o
	for qemu-devel@nongnu.org; Thu, 30 Jul 2009 10:35:14 -0400
Message-ID: <4A71AF9C.7020500@redhat.com>
Date: Thu, 30 Jul 2009 16:35:08 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 4/5] QemuOpts: add -drive-set option
References: <1248950621-22249-1-git-send-email-kraxel@redhat.com>
	<1248950621-22249-5-git-send-email-kraxel@redhat.com>
	<4A71A71E.3030101@codemonkey.ws>
In-Reply-To: <4A71A71E.3030101@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

On 07/30/09 15:58, Anthony Liguori wrote:
> Gerd Hoffmann wrote:
>> The typical use case will be file (no filename quoting issues), i.e.
>>
>> -drive id=test,if=virtio
>> -drive-set test.file=/vmdisk/test-virtio.img
>
> I'm not a big fan of this syntax because you still end up with not
> putting a filename as a single argument.

You can take everything after '=' as-is though, so the parsing/quoting 
issues are gone nevertheless.

> I don't think it extends very
> well to other option types either like -net.

Problem with the "-drive.$id.$arg $value" syntax suggested by you is 
that the qemu option parser can handle fixed -option strings only.

Other ideas?

cheers,
   Gerd