From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MWXFa-0006X7-QH for qemu-devel@nongnu.org; Thu, 30 Jul 2009 11:08:58 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MWXFV-0006Uf-RM for qemu-devel@nongnu.org; Thu, 30 Jul 2009 11:08:58 -0400 Received: from [199.232.76.173] (port=52096 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWXFV-0006Uc-KA for qemu-devel@nongnu.org; Thu, 30 Jul 2009 11:08:53 -0400 Received: from mx2.redhat.com ([66.187.237.31]:38678) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MWXFV-0002xe-4z for qemu-devel@nongnu.org; Thu, 30 Jul 2009 11:08:53 -0400 Message-ID: <4A71B89C.4030803@redhat.com> Date: Thu, 30 Jul 2009 18:13:32 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1248818713-11261-1-git-send-email-lcapitulino@redhat.com> <1248818713-11261-2-git-send-email-lcapitulino@redhat.com> <4A701AA3.4060902@redhat.com> <20090729104600.17deb355@doriath> <4A705536.3020305@redhat.com> <20090729112220.16ffe414@doriath> <4A705EAB.1030200@redhat.com> <20090729131131.2d5e4fa6@doriath> <4A70769A.7000404@redhat.com> <20090730115051.53495100@doriath> <5b31733c0907300804n5ccb1c7cla77e193b90718eb6@mail.gmail.com> In-Reply-To: <5b31733c0907300804n5ccb1c7cla77e193b90718eb6@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 01/25] Introduce QEMU dictionary data type List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Filip Navara Cc: aliguori@us.ibm.com, jan.kiszka@siemens.com, dlaor@redhat.com, qemu-devel@nongnu.org, Luiz Capitulino On 07/30/2009 06:04 PM, Filip Navara wrote: > Again, intptr_t should be used here in long term. long is probably > fine for now before I post the Win64 patches. > No, for the long term we shouldn't be putting pointers into integers or vice versa unless there's a really good reason to do so. The existing code should have been written with a union or something (which would have prevented the need for splitting words). -- error compiling committee.c: too many arguments to function