From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MWac2-00084b-8b
	for qemu-devel@nongnu.org; Thu, 30 Jul 2009 14:44:22 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MWabx-000830-Hb
	for qemu-devel@nongnu.org; Thu, 30 Jul 2009 14:44:21 -0400
Received: from [199.232.76.173] (port=53571 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MWabx-00082t-BJ
	for qemu-devel@nongnu.org; Thu, 30 Jul 2009 14:44:17 -0400
Received: from mail-qy0-f174.google.com ([209.85.221.174]:34462)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MWabw-0000Je-LK
	for qemu-devel@nongnu.org; Thu, 30 Jul 2009 14:44:16 -0400
Received: by qyk4 with SMTP id 4so2091299qyk.4
	for <qemu-devel@nongnu.org>; Thu, 30 Jul 2009 11:44:15 -0700 (PDT)
Message-ID: <4A71E9FB.5010004@codemonkey.ws>
Date: Thu, 30 Jul 2009 13:44:11 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 4/5] QemuOpts: add -drive-set option
References: <1248950621-22249-1-git-send-email-kraxel@redhat.com>
	<1248950621-22249-5-git-send-email-kraxel@redhat.com>
	<4A71A71E.3030101@codemonkey.ws> <4A71AF9C.7020500@redhat.com>
In-Reply-To: <4A71AF9C.7020500@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Gerd Hoffmann wrote:
> On 07/30/09 15:58, Anthony Liguori wrote:
>> Gerd Hoffmann wrote:
>>> The typical use case will be file (no filename quoting issues), i.e.
>>>
>>> -drive id=test,if=virtio
>>> -drive-set test.file=/vmdisk/test-virtio.img
>>
>> I'm not a big fan of this syntax because you still end up with not
>> putting a filename as a single argument.
>
> You can take everything after '=' as-is though, so the parsing/quoting 
> issues are gone nevertheless.
>
>> I don't think it extends very
>> well to other option types either like -net.
>
> Problem with the "-drive.$id.$arg $value" syntax suggested by you is 
> that the qemu option parser can handle fixed -option strings only.

Right, but that shouldn't stop us if we think it's the right syntax.

But in the very least, instead of a -drive-set, -net-set, etc., I would 
rather that we had a single -set command that was like:

-set drive.test.file=/vmdisk/test-virtio.img

Whereas this could map into a config file fragment.  Our host config 
file could then look like:

drive.test.file = "/vmdisk/test-virtio.img"

or:

[drive.test]
file = "/vmdisk/test-virtio.img"

I don't really know the right syntax, but that's where we should be heading.

Regards,

Anthony Liguori