From: Anthony Liguori <anthony@codemonkey.ws>
To: Pantelis Koukousoulas <pktoss@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Add support for vmware vmdk scsi images to qemu-img
Date: Thu, 30 Jul 2009 13:49:50 -0500 [thread overview]
Message-ID: <4A71EB4E.3070904@codemonkey.ws> (raw)
In-Reply-To: <1248969319-8704-1-git-send-email-pktoss@gmail.com>
Pantelis Koukousoulas wrote:
> diff --git a/block_int.h b/block_int.h
> index 830b7e9..0311198 100644
> --- a/block_int.h
> +++ b/block_int.h
> @@ -30,10 +30,12 @@
> #define BLOCK_FLAG_ENCRYPT 1
> #define BLOCK_FLAG_COMPRESS 2
> #define BLOCK_FLAG_COMPAT6 4
> +#define BLOCK_FLAG_SCSI 8
The flag space is limited and I don't want to pollute it with options
that are of no use to QEMU. If you were able to limit the impact of
this patch to just block/vmdk.c, we would be more likely to consider
it. That may require a greater refactoring of how options work though.
I wish we never took compat6 :-/
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-07-30 18:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-30 15:55 [Qemu-devel] [PATCH] Add support for vmware vmdk scsi images to qemu-img Pantelis Koukousoulas
2009-07-30 16:27 ` Paul Brook
2009-07-30 17:11 ` Pantelis Koukousoulas
2009-07-30 18:49 ` Anthony Liguori [this message]
2009-08-12 13:48 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A71EB4E.3070904@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=pktoss@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).