From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MWahT-0001YW-6B for qemu-devel@nongnu.org; Thu, 30 Jul 2009 14:49:59 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MWahO-0001Wj-Hw for qemu-devel@nongnu.org; Thu, 30 Jul 2009 14:49:58 -0400 Received: from [199.232.76.173] (port=60744 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWahO-0001WZ-B2 for qemu-devel@nongnu.org; Thu, 30 Jul 2009 14:49:54 -0400 Received: from mail-qy0-f174.google.com ([209.85.221.174]:60780) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MWahN-0001bW-R0 for qemu-devel@nongnu.org; Thu, 30 Jul 2009 14:49:54 -0400 Received: by qyk4 with SMTP id 4so2095807qyk.4 for ; Thu, 30 Jul 2009 11:49:53 -0700 (PDT) Message-ID: <4A71EB4E.3070904@codemonkey.ws> Date: Thu, 30 Jul 2009 13:49:50 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Add support for vmware vmdk scsi images to qemu-img References: <1248969319-8704-1-git-send-email-pktoss@gmail.com> In-Reply-To: <1248969319-8704-1-git-send-email-pktoss@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pantelis Koukousoulas Cc: qemu-devel@nongnu.org Pantelis Koukousoulas wrote: > diff --git a/block_int.h b/block_int.h > index 830b7e9..0311198 100644 > --- a/block_int.h > +++ b/block_int.h > @@ -30,10 +30,12 @@ > #define BLOCK_FLAG_ENCRYPT 1 > #define BLOCK_FLAG_COMPRESS 2 > #define BLOCK_FLAG_COMPAT6 4 > +#define BLOCK_FLAG_SCSI 8 The flag space is limited and I don't want to pollute it with options that are of no use to QEMU. If you were able to limit the impact of this patch to just block/vmdk.c, we would be more likely to consider it. That may require a greater refactoring of how options work though. I wish we never took compat6 :-/ Regards, Anthony Liguori