From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MWuFp-0005vG-6R for qemu-devel@nongnu.org; Fri, 31 Jul 2009 11:42:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MWuFj-0005r9-SK for qemu-devel@nongnu.org; Fri, 31 Jul 2009 11:42:44 -0400 Received: from [199.232.76.173] (port=37710 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWuFj-0005qx-Mj for qemu-devel@nongnu.org; Fri, 31 Jul 2009 11:42:39 -0400 Received: from mx2.redhat.com ([66.187.237.31]:59440) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MWuFj-0001cy-1Q for qemu-devel@nongnu.org; Fri, 31 Jul 2009 11:42:39 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n6VFgRWX027198 for ; Fri, 31 Jul 2009 11:42:27 -0400 Message-ID: <4A7310DF.9070904@redhat.com> Date: Fri, 31 Jul 2009 17:42:23 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [RfC PATCH 2/2] qdev/prop: convert pci.c to helper macros. References: <1249045499-10973-1-git-send-email-kraxel@redhat.com> <1249045499-10973-3-git-send-email-kraxel@redhat.com> <20090731143251.GA9233@redhat.com> In-Reply-To: <20090731143251.GA9233@redhat.com> Content-Type: multipart/mixed; boundary="------------030807040402070907030704" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org This is a multi-part message in MIME format. --------------030807040402070907030704 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mx2.redhat.com id n6VFgRWX027198 Hi, > (long)(&(_prop)->type -&((_struct *)0)->_field)) \ > This seems to be free of gcc extensions and gives more or less sane err= ors like: > > foo.c:26: error: invalid operands to binary - (have =E2=80=98long long = int *=E2=80=99 and =E2=80=98int *=E2=80=99) The "better error message" bit works. Nice idea. Incremental patch=20 attached. cheers, Gerd --------------030807040402070907030704 Content-Type: text/plain; name="0001-better-type-check.patch" Content-Disposition: attachment; filename="0001-better-type-check.patch" Content-Transfer-Encoding: base64 RnJvbSBjZjRkNjNjNDU2MjUwYzdlOTc3MDUzMzhjM2MwNTJmZTEwYTVhNGI2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBHZXJkIEhvZmZtYW5uIDxrcmF4ZWxAcmVkaGF0LmNv bT4KRGF0ZTogRnJpLCAzMSBKdWwgMjAwOSAxNzozNjowMSArMDIwMApTdWJqZWN0OiBbUEFU Q0hdIGJldHRlciB0eXBlIGNoZWNrCgotLS0KIGh3L3FkZXYuaCB8ICAgIDQgKy0tLQogMSBm aWxlcyBjaGFuZ2VkLCAxIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvaHcvcWRldi5oIGIvaHcvcWRldi5oCmluZGV4IDRmZTUzNGUuLmUyNzAzZjQgMTAw NjQ0Ci0tLSBhL2h3L3FkZXYuaAorKysgYi9ody9xZGV2LmgKQEAgLTE1NiwxMCArMTU2LDgg QEAgZXh0ZXJuIFByb3BlcnR5SW5mbyBxZGV2X3Byb3BfcHRyOwogZXh0ZXJuIFByb3BlcnR5 SW5mbyBxZGV2X3Byb3BfbWFjYWRkcjsKIGV4dGVybiBQcm9wZXJ0eUluZm8gcWRldl9wcm9w X3BjaV9kZXZmbjsKIAotZXh0ZXJuIGludCBxZGV2X3Byb3BlcnR5X3R5cGVfY2hlY2tfZmFp bGVkOyAvKiB1bmRlZmluZWQgKi8KICNkZWZpbmUgdHlwZW9mX2ZpZWxkKHR5cGUsIGZpZWxk KSB0eXBlb2YoKCh0eXBlICopMCktPmZpZWxkKQotI2RlZmluZSB0eXBlX2NoZWNrKHQxLHQy KSBfX2J1aWx0aW5fY2hvb3NlX2V4cHIoIFwKLSAgICAgICAgX19idWlsdGluX3R5cGVzX2Nv bXBhdGlibGVfcCh0MSx0MiksMCxxZGV2X3Byb3BlcnR5X3R5cGVfY2hlY2tfZmFpbGVkKQor I2RlZmluZSB0eXBlX2NoZWNrKHQxLHQyKSAoKHQxKikwIC0gKHQyKikwKQogCiAjZGVmaW5l IERFRklORV9QUk9QKF9uYW1lLCBfc3RhdGUsIF9maWVsZCwgX3Byb3AsIF90eXBlKSB7IFwK ICAgICAgICAgLm5hbWUgICAgICA9IChfbmFtZSksICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgXAotLSAKMS42LjIuNQoK --------------030807040402070907030704--