[Qemu-devel] [PATCH] Win32: Fix default prefix

[Qemu-devel] [PATCH] Win32: Fix default prefix

[Stefan Weil]

The old code resulted in wrong escape sequences:

#define CONFIG_QEMU_SHAREDIR "c:\Program Files\Qemu"

gcc warnings:

vl.c:5708:20: warning: unknown escape sequence '\P'
vl.c:5708:20: warning: unknown escape sequence '\Q'

Windows can handle slash (/) path separators,
and QEMU already adds directories using slash,
so there is no need to fight with the correct number
of backslashes.

Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
 configure |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/configure b/configure
index a2e22ad..e556698 100755
--- a/configure
+++ b/configure
@@ -1409,7 +1409,7 @@ fi
 
 if test "$mingw32" = "yes" ; then
   if test -z "$prefix" ; then
-      prefix="c:\\\\Program Files\\\\Qemu"
+      prefix="c:/Program Files/Qemu"
   fi
   mansuffix=""
   datasuffix=""
-- 
1.5.6.5

[Qemu-devel] Re: [PATCH] Win32: Fix default prefix

[Sebastian Herbszt]

Stefan Weil wrote:
> The old code resulted in wrong escape sequences:
> 
> #define CONFIG_QEMU_SHAREDIR "c:\Program Files\Qemu"
> 
> gcc warnings:
> 
> vl.c:5708:20: warning: unknown escape sequence '\P'
> vl.c:5708:20: warning: unknown escape sequence '\Q'

Looks like this got broken by "Generate config-host.h from config-host.mak" (create_config).

> Windows can handle slash (/) path separators,
> and QEMU already adds directories using slash,
> so there is no need to fight with the correct number
> of backslashes.

Do all versions handle them correctly?

- Sebastian

Re: [Qemu-devel] Re: [PATCH] Win32: Fix default prefix

[Filip Navara]

On Sat, Aug 1, 2009 at 11:35 PM, Sebastian Herbszt<herbszt@gmx.de> wrote:
> Stefan Weil wrote:
>>
>> The old code resulted in wrong escape sequences:
>>
>> #define CONFIG_QEMU_SHAREDIR "c:\Program Files\Qemu"
>>
>> gcc warnings:
>>
>> vl.c:5708:20: warning: unknown escape sequence '\P'
>> vl.c:5708:20: warning: unknown escape sequence '\Q'
>
> Looks like this got broken by "Generate config-host.h from config-host.mak"
> (create_config).
>
>> Windows can handle slash (/) path separators,
>> and QEMU already adds directories using slash,
>> so there is no need to fight with the correct number
>> of backslashes.
>
> Do all versions handle them correctly?

At least all NT-based versions do and I believe Win 9x handles them
correctly too.

Best regards,
Filip Navara

Re: [Qemu-devel] [PATCH] Win32: Fix default prefix

[Stefan Weil]

Filip Navara schrieb:
> On Sat, Aug 1, 2009 at 11:35 PM, Sebastian Herbszt<herbszt@gmx.de> wrote:
>   
>> Stefan Weil wrote:
>>     
>>> The old code resulted in wrong escape sequences:
>>>
>>> #define CONFIG_QEMU_SHAREDIR "c:\Program Files\Qemu"
>>>
>>> gcc warnings:
>>>
>>> vl.c:5708:20: warning: unknown escape sequence '\P'
>>> vl.c:5708:20: warning: unknown escape sequence '\Q'
>>>       
>> Looks like this got broken by "Generate config-host.h from config-host.mak"
>> (create_config).
>>
>>     
>>> Windows can handle slash (/) path separators,
>>> and QEMU already adds directories using slash,
>>> so there is no need to fight with the correct number
>>> of backslashes.
>>>       
>> Do all versions handle them correctly?
>>     
>
> At least all NT-based versions do and I believe Win 9x handles them
> correctly too.
>
> Best regards,
> Filip Navara
>
>   

Even IBM BIOS and all versions of MSDOS I know accept slash and backslash
in parameters for file system calls. So do all versions of Windows, too,

Regards
Stefan Weil