From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MXbhH-0007CG-JX for qemu-devel@nongnu.org; Sun, 02 Aug 2009 10:05:59 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MXbhB-0007C3-2V for qemu-devel@nongnu.org; Sun, 02 Aug 2009 10:05:59 -0400 Received: from [199.232.76.173] (port=37810 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MXbhA-0007C0-Vf for qemu-devel@nongnu.org; Sun, 02 Aug 2009 10:05:52 -0400 Received: from mx2.redhat.com ([66.187.237.31]:35365) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MXbhA-0007Dr-BZ for qemu-devel@nongnu.org; Sun, 02 Aug 2009 10:05:52 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n72E5Pqt009011 for ; Sun, 2 Aug 2009 10:05:36 -0400 Message-ID: <4A759E55.7070102@redhat.com> Date: Sun, 02 Aug 2009 17:10:29 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/2] qdev/core: add monitor command to list all drivers References: <1248865944-15937-1-git-send-email-kraxel@redhat.com> <1248865944-15937-2-git-send-email-kraxel@redhat.com> In-Reply-To: <1248865944-15937-2-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On 07/29/2009 02:12 PM, Gerd Hoffmann wrote: > > diff --git a/monitor.c b/monitor.c > index 99c174c..9093254 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -1882,6 +1882,8 @@ static const mon_cmd_t info_cmds[] = { > "", "show balloon information" }, > { "qtree", "", do_info_qtree, > "", "show device tree" }, > + { "qdrv", "", do_info_qdrv, > + "", "show qdev driver list" }, > { NULL, NULL, }, > }; > Drivers are guest things. You're listing device models, not drivers. -- error compiling committee.c: too many arguments to function