[Qemu-devel] [PATCH] Fix do_commit() behavior

[Qemu-devel] [PATCH] Fix do_commit() behavior

[Luiz Capitulino]

Commit 751c6a17042b5d011013d6963c0505d671cf708e changed the monitor's
'commit' command to this behavior:

1. Any string you type as argument will cause do_commit() to
call bdrv_commit() to all devices

2. If you enter a device name, it will be the only one ignored
by do_commit() :)

The fix is to call bdrv_commit() to the specified device only and
ignore the others (when 'all' is not specified).

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 monitor.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/monitor.c b/monitor.c
index 9093254..32fc26a 100644
--- a/monitor.c
+++ b/monitor.c
@@ -259,7 +259,7 @@ static void do_commit(Monitor *mon, const char *device)
     all_devices = !strcmp(device, "all");
     TAILQ_FOREACH(dinfo, &drives, next) {
         if (!all_devices)
-            if (!strcmp(bdrv_get_device_name(dinfo->bdrv), device))
+            if (strcmp(bdrv_get_device_name(dinfo->bdrv), device))
                 continue;
         bdrv_commit(dinfo->bdrv);
     }
-- 
1.6.4.rc3.12.gdf73a

[Qemu-devel] Re: [PATCH] Fix do_commit() behavior

[Gerd Hoffmann]

On 07/31/09 20:15, Luiz Capitulino wrote:
> The fix is to call bdrv_commit() to the specified device only and
> ignore the others (when 'all' is not specified).

>       all_devices = !strcmp(device, "all");
>       TAILQ_FOREACH(dinfo,&drives, next) {
>           if (!all_devices)
> -            if (!strcmp(bdrv_get_device_name(dinfo->bdrv), device))
> +            if (strcmp(bdrv_get_device_name(dinfo->bdrv), device))
>                   continue;
>           bdrv_commit(dinfo->bdrv);
>       }

Fix is correct.

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

cheers,
   Gerd

Re: [Qemu-devel] [PATCH] Fix do_commit() behavior

[Avi Kivity]

On 07/31/2009 09:15 PM, Luiz Capitulino wrote:
>       all_devices = !strcmp(device, "all");
>       TAILQ_FOREACH(dinfo,&drives, next) {
>           if (!all_devices)
> -            if (!strcmp(bdrv_get_device_name(dinfo->bdrv), device))
> +            if (strcmp(bdrv_get_device_name(dinfo->bdrv), device))
>                   continue;
>           bdrv_commit(dinfo->bdrv);
>       }
>    

strcmp() without == 0 or != 0 is evil, as is !strcmp().  strcmp() does 
not return a boolean value or a count.


-- 
error compiling committee.c: too many arguments to function