From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MXtDE-0003sK-3P
	for qemu-devel@nongnu.org; Mon, 03 Aug 2009 04:48:08 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MXtD9-0003qZ-G0
	for qemu-devel@nongnu.org; Mon, 03 Aug 2009 04:48:07 -0400
Received: from [199.232.76.173] (port=34886 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MXtD9-0003qL-3e
	for qemu-devel@nongnu.org; Mon, 03 Aug 2009 04:48:03 -0400
Received: from mx2.redhat.com ([66.187.237.31]:33664)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MXtD8-000671-Il
	for qemu-devel@nongnu.org; Mon, 03 Aug 2009 04:48:02 -0400
Message-ID: <4A76A43E.9060406@redhat.com>
Date: Mon, 03 Aug 2009 10:47:58 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <20090731151541.701b8c60@doriath>
In-Reply-To: <20090731151541.701b8c60@doriath>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] Fix do_commit() behavior
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

On 07/31/09 20:15, Luiz Capitulino wrote:
> The fix is to call bdrv_commit() to the specified device only and
> ignore the others (when 'all' is not specified).

>       all_devices = !strcmp(device, "all");
>       TAILQ_FOREACH(dinfo,&drives, next) {
>           if (!all_devices)
> -            if (!strcmp(bdrv_get_device_name(dinfo->bdrv), device))
> +            if (strcmp(bdrv_get_device_name(dinfo->bdrv), device))
>                   continue;
>           bdrv_commit(dinfo->bdrv);
>       }

Fix is correct.

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

cheers,
   Gerd