From: Gerd Hoffmann <kraxel@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] qdev/core: add monitor command to list all drivers
Date: Mon, 03 Aug 2009 12:05:56 +0200 [thread overview]
Message-ID: <4A76B684.6040203@redhat.com> (raw)
In-Reply-To: <4A759E55.7070102@redhat.com>
On 08/02/09 16:10, Avi Kivity wrote:
> On 07/29/2009 02:12 PM, Gerd Hoffmann wrote:
>>
>> diff --git a/monitor.c b/monitor.c
>> index 99c174c..9093254 100644
>> --- a/monitor.c
>> +++ b/monitor.c
>> @@ -1882,6 +1882,8 @@ static const mon_cmd_t info_cmds[] = {
>> "", "show balloon information" },
>> { "qtree", "", do_info_qtree,
>> "", "show device tree" },
>> + { "qdrv", "", do_info_qdrv,
>> + "", "show qdev driver list" },
>> { NULL, NULL, },
>> };
>
> Drivers are guest things. You're listing device models, not drivers.
Strictly speaking you are correct. But qemu is quite sloppy here and
calls the device models drivers (almost?) everythere, so I'd tend to
stick with it for consistency ...
cheers,
Gerd
next prev parent reply other threads:[~2009-08-03 10:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-29 11:12 [Qemu-devel] [PATCH 1/2] qdev: factor out qdev_print_devinfo Gerd Hoffmann
2009-07-29 11:12 ` [Qemu-devel] [PATCH 2/2] qdev/core: add monitor command to list all drivers Gerd Hoffmann
2009-08-02 14:10 ` Avi Kivity
2009-08-03 10:05 ` Gerd Hoffmann [this message]
2009-08-03 12:51 ` Avi Kivity
2009-07-31 23:44 ` [Qemu-devel] [PATCH 1/2] qdev: factor out qdev_print_devinfo Markus Armbruster
2009-08-03 7:50 ` Gerd Hoffmann
2009-08-03 8:24 ` Markus Armbruster
2009-08-03 9:23 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A76B684.6040203@redhat.com \
--to=kraxel@redhat.com \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).