From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MXwvj-0001y8-3d for qemu-devel@nongnu.org; Mon, 03 Aug 2009 08:46:19 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MXwve-0001s7-8f for qemu-devel@nongnu.org; Mon, 03 Aug 2009 08:46:18 -0400 Received: from [199.232.76.173] (port=35772 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MXwve-0001s1-6S for qemu-devel@nongnu.org; Mon, 03 Aug 2009 08:46:14 -0400 Received: from mx2.redhat.com ([66.187.237.31]:50437) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MXwvd-00061d-M5 for qemu-devel@nongnu.org; Mon, 03 Aug 2009 08:46:13 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n73CkCUV005475 for ; Mon, 3 Aug 2009 08:46:12 -0400 Message-ID: <4A76DD4F.7000508@redhat.com> Date: Mon, 03 Aug 2009 15:51:27 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/2] qdev/core: add monitor command to list all drivers References: <1248865944-15937-1-git-send-email-kraxel@redhat.com> <1248865944-15937-2-git-send-email-kraxel@redhat.com> <4A759E55.7070102@redhat.com> <4A76B684.6040203@redhat.com> In-Reply-To: <4A76B684.6040203@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On 08/03/2009 01:05 PM, Gerd Hoffmann wrote: > On 08/02/09 16:10, Avi Kivity wrote: >> On 07/29/2009 02:12 PM, Gerd Hoffmann wrote: >>> >>> diff --git a/monitor.c b/monitor.c >>> index 99c174c..9093254 100644 >>> --- a/monitor.c >>> +++ b/monitor.c >>> @@ -1882,6 +1882,8 @@ static const mon_cmd_t info_cmds[] = { >>> "", "show balloon information" }, >>> { "qtree", "", do_info_qtree, >>> "", "show device tree" }, >>> + { "qdrv", "", do_info_qdrv, >>> + "", "show qdev driver list" }, >>> { NULL, NULL, }, >>> }; >> >> Drivers are guest things. You're listing device models, not drivers. > > Strictly speaking you are correct. But qemu is quite sloppy here and > calls the device models drivers (almost?) everythere, so I'd tend to > stick with it for consistency ... Consistently incorrect? Given that it's an external ABI, let's not be sloppy here. -- error compiling committee.c: too many arguments to function