qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 14/32] qdev/prop: convert qdev.c to helper macros.
Date: Tue, 04 Aug 2009 08:27:15 -0500	[thread overview]
Message-ID: <4A783733.6050805@codemonkey.ws> (raw)
In-Reply-To: <1249313748-6459-15-git-send-email-kraxel@redhat.com>

Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  hw/qdev.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/qdev.c b/hw/qdev.c
> index 9488dba..3de3bc9 100644
> --- a/hw/qdev.c
> +++ b/hw/qdev.c
> @@ -543,8 +543,8 @@ static void qdev_print_props(Monitor *mon, DeviceState *dev, Property *props,
>      if (!props)
>          return;
>      while (props->name) {
> -        if (props->info->print) {
> -            props->info->print(dev, props, buf, sizeof(buf));
> +        if (props->xinfo->print) {
> +            props->xinfo->print(dev, props, buf, sizeof(buf));
>              qdev_printf("%s-prop: %s = %s\n", prefix, props->name, buf);
>          }
>          props++;
>   
This doesn't match the description and breaks the build for me.

Regards,

Anthony Liguori

  reply	other threads:[~2009-08-04 13:27 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-03 15:35 [Qemu-devel] [PATCH 00/32] qdev: macros for creating typechecked properties Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 01/32] qdev/prop: " Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 02/32] qdev/prop: add CharDriverState property Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 03/32] qdev/prop: convert pci.c to helper macros Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 04/32] qdev/prop: convert arm_sysctl.c " Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 05/32] qdev/prop: convert armv7m.c " Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 06/32] qdev/prop: convert eccmemctl.c " Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 07/32] qdev/prop: convert escc.c " Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 08/32] qdev/prop: convert etraxfs_pic.c " Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 09/32] qdev/prop: convert i2c.c " Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 10/32] qdev/prop: convert integratorcp.c " Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 11/32] qdev/prop: convert iommu.c " Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 12/32] qdev/prop: convert m48t59.c " Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 13/32] qdev/prop: convert pcnet.c " Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 14/32] qdev/prop: convert qdev.c " Gerd Hoffmann
2009-08-04 13:27   ` Anthony Liguori [this message]
2009-08-04 13:43     ` Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 15/32] qdev/prop: convert slavio_intctl.c " Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 16/32] qdev/prop: convert slavio_timer.c " Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 17/32] qdev/prop: convert smbus_eeprom.c " Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 18/32] qdev/prop: convert sparc32_dma.c " Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 19/32] qdev/prop: convert sun4m.c " Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 20/32] qdev/prop: convert sun4u.c " Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 21/32] qdev/prop: convert syborg_fb.c " Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 22/32] qdev/prop: convert syborg_interrupt.c " Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 23/32] qdev/prop: convert syborg_keyboard.c " Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 24/32] qdev/prop: convert syborg_pointer.c " Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 25/32] qdev/prop: convert syborg_serial.c " Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 26/32] qdev/prop: convert syborg_timer.c " Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 27/32] qdev/prop: convert tcx.c " Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 28/32] qdev/prop: convert vga.c " Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 29/32] qdev/prop: convert virtio-pci.c " Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 30/32] qdev/prop: convert xilinx_ethlite.c " Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 31/32] qdev/prop: convert xilinx_intc.c " Gerd Hoffmann
2009-08-03 15:35 ` [Qemu-devel] [PATCH 32/32] qdev/prop: convert xilinx_timer.c " Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A783733.6050805@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).