From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MYK31-0002oN-MB for qemu-devel@nongnu.org; Tue, 04 Aug 2009 09:27:23 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MYK2x-0002n8-VX for qemu-devel@nongnu.org; Tue, 04 Aug 2009 09:27:23 -0400 Received: from [199.232.76.173] (port=34907 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MYK2x-0002n5-QO for qemu-devel@nongnu.org; Tue, 04 Aug 2009 09:27:19 -0400 Received: from qw-out-1920.google.com ([74.125.92.145]:37714) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MYK2x-00088h-F7 for qemu-devel@nongnu.org; Tue, 04 Aug 2009 09:27:19 -0400 Received: by qw-out-1920.google.com with SMTP id 5so1858281qwc.4 for ; Tue, 04 Aug 2009 06:27:17 -0700 (PDT) Message-ID: <4A783733.6050805@codemonkey.ws> Date: Tue, 04 Aug 2009 08:27:15 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 14/32] qdev/prop: convert qdev.c to helper macros. References: <1249313748-6459-1-git-send-email-kraxel@redhat.com> <1249313748-6459-15-git-send-email-kraxel@redhat.com> In-Reply-To: <1249313748-6459-15-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > hw/qdev.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/qdev.c b/hw/qdev.c > index 9488dba..3de3bc9 100644 > --- a/hw/qdev.c > +++ b/hw/qdev.c > @@ -543,8 +543,8 @@ static void qdev_print_props(Monitor *mon, DeviceState *dev, Property *props, > if (!props) > return; > while (props->name) { > - if (props->info->print) { > - props->info->print(dev, props, buf, sizeof(buf)); > + if (props->xinfo->print) { > + props->xinfo->print(dev, props, buf, sizeof(buf)); > qdev_printf("%s-prop: %s = %s\n", prefix, props->name, buf); > } > props++; > This doesn't match the description and breaks the build for me. Regards, Anthony Liguori