From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MYKJC-0007fQ-J0
	for qemu-devel@nongnu.org; Tue, 04 Aug 2009 09:44:06 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MYKJ8-0007e2-RC
	for qemu-devel@nongnu.org; Tue, 04 Aug 2009 09:44:06 -0400
Received: from [199.232.76.173] (port=51953 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MYKJ8-0007dy-If
	for qemu-devel@nongnu.org; Tue, 04 Aug 2009 09:44:02 -0400
Received: from mx2.redhat.com ([66.187.237.31]:50195)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MYKJ8-00031J-3A
	for qemu-devel@nongnu.org; Tue, 04 Aug 2009 09:44:02 -0400
Message-ID: <4A783B19.40004@redhat.com>
Date: Tue, 04 Aug 2009 15:43:53 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 14/32] qdev/prop: convert qdev.c to helper
	macros.
References: <1249313748-6459-1-git-send-email-kraxel@redhat.com>
	<1249313748-6459-15-git-send-email-kraxel@redhat.com>
	<4A783733.6050805@codemonkey.ws>
In-Reply-To: <4A783733.6050805@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

On 08/04/09 15:27, Anthony Liguori wrote:
> Gerd Hoffmann wrote:
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>> ---
>> hw/qdev.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/hw/qdev.c b/hw/qdev.c
>> index 9488dba..3de3bc9 100644
>> --- a/hw/qdev.c
>> +++ b/hw/qdev.c
>> @@ -543,8 +543,8 @@ static void qdev_print_props(Monitor *mon,
>> DeviceState *dev, Property *props,
>> if (!props)
>> return;
>> while (props->name) {
>> - if (props->info->print) {
>> - props->info->print(dev, props, buf, sizeof(buf));
>> + if (props->xinfo->print) {
>> + props->xinfo->print(dev, props, buf, sizeof(buf));
>> qdev_printf("%s-prop: %s = %s\n", prefix, props->name, buf);
>> }
>> props++;
> This doesn't match the description and breaks the build for me.

Indeed.  Just drop that patch.

It is part of a little temporary patch to make gcc complain about any 
not-yet converted property.  It wasn't intended to sneak into public ...

cheers,
   Gerd