From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MZ3T8-0001Jo-F3 for qemu-devel@nongnu.org; Thu, 06 Aug 2009 09:57:22 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MZ3T3-0001HX-Lh for qemu-devel@nongnu.org; Thu, 06 Aug 2009 09:57:21 -0400 Received: from [199.232.76.173] (port=49578 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MZ3T3-0001HO-GH for qemu-devel@nongnu.org; Thu, 06 Aug 2009 09:57:17 -0400 Received: from mx2.redhat.com ([66.187.237.31]:41148) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MZ3T2-0004Vq-Uk for qemu-devel@nongnu.org; Thu, 06 Aug 2009 09:57:17 -0400 Message-ID: <4A7AE288.1020905@redhat.com> Date: Thu, 06 Aug 2009 17:02:48 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1249566736-5020-1-git-send-email-lcapitulino@redhat.com> <1249566736-5020-2-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1249566736-5020-2-git-send-email-lcapitulino@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 1/3] Introduce qobject header file List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: aliguori@us.ibm.com, filip.navara@gmail.com, qemu-devel@nongnu.org On 08/06/2009 04:52 PM, Luiz Capitulino wrote: > This file contains basic definitions for the QEMU Object Model, > all object implementions must include this file and add its > type code in qtype_t enum. > > > + > +typedef enum { > + QTYPE_NONE, > +} qtype_t; > + > +struct QObject; > + > +typedef struct QType { > + qtype_t code; > Is this really needed? You can check if an object is a particular type by checking its ->type agains whatever you're interested in. Of course you should refrain from doing so unless there's no choice. -- error compiling committee.c: too many arguments to function