From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MZ3V6-0001ya-En for qemu-devel@nongnu.org; Thu, 06 Aug 2009 09:59:24 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MZ3V1-0001wR-Oa for qemu-devel@nongnu.org; Thu, 06 Aug 2009 09:59:24 -0400 Received: from [199.232.76.173] (port=49605 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MZ3V1-0001wL-Ky for qemu-devel@nongnu.org; Thu, 06 Aug 2009 09:59:19 -0400 Received: from mx2.redhat.com ([66.187.237.31]:51793) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MZ3V1-0004ms-1E for qemu-devel@nongnu.org; Thu, 06 Aug 2009 09:59:19 -0400 Message-ID: <4A7AE302.30304@redhat.com> Date: Thu, 06 Aug 2009 17:04:50 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1249566736-5020-1-git-send-email-lcapitulino@redhat.com> <1249566736-5020-4-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1249566736-5020-4-git-send-email-lcapitulino@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 3/3] Introduce QNumber data type List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: aliguori@us.ibm.com, filip.navara@gmail.com, qemu-devel@nongnu.org On 08/06/2009 04:52 PM, Luiz Capitulino wrote: > + > +typedef struct QNumber { > + QObject base; > + union { > + int n_int; > + int64_t n_int64; > + } number; > +} QNumber; > Why not have an int64_t exclusively? Also, we need floating point support. So probably need to split this into QInt and QFloat. -- error compiling committee.c: too many arguments to function