From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MaQOW-0002EN-01 for qemu-devel@nongnu.org; Mon, 10 Aug 2009 04:38:16 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MaQOQ-0002DR-No for qemu-devel@nongnu.org; Mon, 10 Aug 2009 04:38:15 -0400 Received: from [199.232.76.173] (port=33266 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MaQOQ-0002DO-Lc for qemu-devel@nongnu.org; Mon, 10 Aug 2009 04:38:10 -0400 Received: from mx20.gnu.org ([199.232.41.8]:27676) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MaQOP-0003BD-FE for qemu-devel@nongnu.org; Mon, 10 Aug 2009 04:38:09 -0400 Received: from mx2.redhat.com ([66.187.237.31]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MaQOO-0006Bn-Pr for qemu-devel@nongnu.org; Mon, 10 Aug 2009 04:38:09 -0400 Message-ID: <4A7FDC6A.30102@redhat.com> Date: Mon, 10 Aug 2009 10:38:02 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/2] Route IOAPIC interrupts via ISA bus References: <1249836296-13288-1-git-send-email-avi@redhat.com> <1249836296-13288-3-git-send-email-avi@redhat.com> In-Reply-To: <1249836296-13288-3-git-send-email-avi@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org Hi, > typedef struct isa_irq_state { > qemu_irq *i8259; > + qemu_irq *ioapic; > } IsaIrqState; Well. Now it would probably better named "pc_irq_state". While that cleanup certainly makes sense it isn't a isa-bus thing any more. cheers, Gerd