From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MaS2k-0005be-DT
	for qemu-devel@nongnu.org; Mon, 10 Aug 2009 06:23:54 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MaS2e-0005Xt-Lg
	for qemu-devel@nongnu.org; Mon, 10 Aug 2009 06:23:53 -0400
Received: from [199.232.76.173] (port=44569 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MaS2d-0005X0-TD
	for qemu-devel@nongnu.org; Mon, 10 Aug 2009 06:23:47 -0400
Received: from mx2.redhat.com ([66.187.237.31]:55028)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <clalance@redhat.com>) id 1MaS2d-00074Z-9w
	for qemu-devel@nongnu.org; Mon, 10 Aug 2009 06:23:47 -0400
Message-ID: <4A7FF52D.6090707@redhat.com>
Date: Mon, 10 Aug 2009 12:23:41 +0200
From: Chris Lalancette <clalance@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Fix detached migration with exec.
References: <1249484855-23277-1-git-send-email-clalance@redhat.com>
In-Reply-To: <1249484855-23277-1-git-send-email-clalance@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

Chris Lalancette wrote:
> When trying to do detached migration with exec, I found that
> the monitor wouldn't always return in a timely manner.  I
> tracked this down to exec_start_outgoing_migration.  It
> appeared we were setting the fd to NONBLOCK'ing, but in
> point of fact we weren't.
> 
> This bugfix should also go onto the stable 0.10 branch

ping?

> 
> Signed-off-by: Chris Lalancette <clalance@redhat.com>
> ---
>  migration-exec.c |    5 +----
>  1 files changed, 1 insertions(+), 4 deletions(-)
> 
> diff --git a/migration-exec.c b/migration-exec.c
> index e3616be..ef4620f 100644
> --- a/migration-exec.c
> +++ b/migration-exec.c
> @@ -73,10 +73,7 @@ MigrationState *exec_start_outgoing_migration(const char *command,
>          goto err_after_open;
>      }
>  
> -    if (fcntl(s->fd, F_SETFD, O_NONBLOCK) == -1) {
> -        dprintf("Unable to set nonblocking mode on file descriptor\n");
> -        goto err_after_open;
> -    }
> +    socket_set_nonblock(s->fd);
>  
>      s->opaque = qemu_popen(f, "w");
>  


-- 
Chris Lalancette