From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MaalN-0005mK-46 for qemu-devel@nongnu.org; Mon, 10 Aug 2009 15:42:33 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MaalH-0005lY-SE for qemu-devel@nongnu.org; Mon, 10 Aug 2009 15:42:32 -0400 Received: from [199.232.76.173] (port=37914 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MaalH-0005lR-Jq for qemu-devel@nongnu.org; Mon, 10 Aug 2009 15:42:27 -0400 Received: from mail-gx0-f220.google.com ([209.85.217.220]:39872) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MaalH-0006ue-8R for qemu-devel@nongnu.org; Mon, 10 Aug 2009 15:42:27 -0400 Received: by gxk20 with SMTP id 20so10238864gxk.10 for ; Mon, 10 Aug 2009 12:42:26 -0700 (PDT) Message-ID: <4A80781F.7040305@codemonkey.ws> Date: Mon, 10 Aug 2009 14:42:23 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 05/14] Change cpu_phys mem callback to use [offset, size) bounds instead of [start, end). References: <1248948912-7877-1-git-send-email-zamsden@redhat.com> <1248948912-7877-2-git-send-email-zamsden@redhat.com> <1248948912-7877-3-git-send-email-zamsden@redhat.com> <1248948912-7877-4-git-send-email-zamsden@redhat.com> <1248948912-7877-5-git-send-email-zamsden@redhat.com> <1248948912-7877-6-git-send-email-zamsden@redhat.com> In-Reply-To: <1248948912-7877-6-git-send-email-zamsden@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zachary Amsden Cc: qemu-devel@nongnu.org Zachary Amsden wrote: > Signed-off-by: Zachary Amsden > --- > cpu-all.h | 2 +- > exec.c | 4 ++-- > hw/cirrus_vga.c | 11 ++++++----- > hw/framebuffer.c | 2 +- > hw/vga.c | 12 ++++++------ > hw/vga_int.h | 2 +- > kvm-all.c | 4 ++-- > 7 files changed, 19 insertions(+), 18 deletions(-) > > diff --git a/cpu-all.h b/cpu-all.h > index 97a224d..43bbf18 100644 > --- a/cpu-all.h > +++ b/cpu-all.h > @@ -907,7 +907,7 @@ int cpu_physical_memory_set_dirty_tracking(int enable); > int cpu_physical_memory_get_dirty_tracking(void); > > int cpu_physical_sync_dirty_bitmap(target_phys_addr_t start_addr, > - target_phys_addr_t end_addr); > + ram_addr_t size); > > void dump_exec_info(FILE *f, > int (*cpu_fprintf)(FILE *f, const char *fmt, ...)); > diff --git a/exec.c b/exec.c > index 688f603..f8bfcd4 100644 > --- a/exec.c > +++ b/exec.c > @@ -1921,12 +1921,12 @@ int cpu_physical_memory_get_dirty_tracking(void) > } > > int cpu_physical_sync_dirty_bitmap(target_phys_addr_t start_addr, > - target_phys_addr_t end_addr) > + ram_addr_t size) > This breaks the build for i386-softmmu as ram_addr_t is a uint32_t there. In vl.c, there's static int ram_save_live(QEMUFile *f, int stage, void *opaque) { ram_addr_t addr; uint64_t bytes_transferred_last; double bwidth = 0; uint64_t expected_time = 0; if (cpu_physical_sync_dirty_bitmap(0, TARGET_PHYS_ADDR_MAX) != 0) { And you get a large integer truncation error. Regards, Anthony Liguori