From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Manfm-0003mF-Dz for qemu-devel@nongnu.org; Tue, 11 Aug 2009 05:29:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Manfh-0003jN-Be for qemu-devel@nongnu.org; Tue, 11 Aug 2009 05:29:37 -0400 Received: from [199.232.76.173] (port=42308 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Manfh-0003j8-4V for qemu-devel@nongnu.org; Tue, 11 Aug 2009 05:29:33 -0400 Received: from mx2.redhat.com ([66.187.237.31]:42058) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Manfg-0006Uh-I3 for qemu-devel@nongnu.org; Tue, 11 Aug 2009 05:29:32 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n7B9TVim012112 for ; Tue, 11 Aug 2009 05:29:31 -0400 Message-ID: <4A813B6F.8040908@redhat.com> Date: Tue, 11 Aug 2009 12:35:43 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Migration via unix sockets. References: <1249485869-23590-1-git-send-email-clalance@redhat.com> <4A7FF53F.2000106@redhat.com> <4A8005B4.9030600@redhat.com> <4A8136CF.5040304@redhat.com> In-Reply-To: <4A8136CF.5040304@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chris Lalancette Cc: qemu-devel@nongnu.org On 08/11/2009 12:15 PM, Chris Lalancette wrote: > A possible implementation of that is attached. I have to say, though, that it > is way more clumsy to use than the unix implementation I posted earlier. On the > outgoing side, you have to use the "getfd" monitor command to pass the fd using > SCM_RIGHTS, then you have to issue another monitor command to start the migration: > > (qemu) getfd migration # passes opened fd via SCM_RIGHTS > (qemu) migrate -d fd:migration > That doesn't seem so bad, especially if you're a program. > On the incoming side, you have to pass the fd via the command-line. That means > that you have to first arrange for it not to be closed on exec, and it also > means that qemu is now depending on the external program to correctly set up the > incoming socket so that qemu can just do the accept() on it. > > I'd like to see a qemu monitor incoming migration command. > None of these problems are insurmountable, but they do make it cumbersome to use > in general, and very difficult to use from the command-line. > These are intended for qemu control programs, not humans. > The other option is that I've misunderstood your intent, and if that is the > case, please correct me where I'm wrong :). > No, I think you got it. -- error compiling committee.c: too many arguments to function