qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Paolo Bonzini <bonzini@gnu.org>
Cc: Chris Lalancette <clalance@redhat.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] Migration via unix sockets.
Date: Tue, 11 Aug 2009 13:06:59 +0300	[thread overview]
Message-ID: <4A8142C3.5020707@redhat.com> (raw)
In-Reply-To: <4A813D94.9020609@gnu.org>

On 08/11/2009 12:44 PM, Paolo Bonzini wrote:
> > That means that you have to first arrange for it not to be closed on
> > exec, and it also means that qemu is now depending on the external
> > program to correctly set up the incoming socket so that qemu can just
> > do the accept() on it.
>
> At this point, I wonder if it isn't better to move the accept to the 
> external program, so that it could even use a pipe.  The accept can be 
> replaced by
>
> struct pollfd pfd;
> pfd.fd = fd;
> pfd.events = POLLIN;
> poll (&pfd, 1, INFTIM);
> if (pfd.revents & (POLLERR | POLLHUP | POLLNVAL))
>   handle_error ();
>
> or the equivalent using select.

Yes, arbitrary fd definitely needs to skip accept().

-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2009-08-11 10:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-05 15:24 [Qemu-devel] [PATCH] Migration via unix sockets Chris Lalancette
2009-08-10 10:23 ` Chris Lalancette
2009-08-10 11:34   ` Avi Kivity
2009-08-11  9:15     ` Chris Lalancette
2009-08-11  9:35       ` Avi Kivity
2009-08-11  9:44       ` [Qemu-devel] " Paolo Bonzini
2009-08-11 10:06         ` Avi Kivity [this message]
2009-08-12 12:20           ` [Qemu-devel] [PATCH] add file descriptor migration Paolo Bonzini
2009-08-18 13:56             ` [Qemu-devel] [PATCH v2] " Paolo Bonzini
2009-08-18 13:59               ` [Qemu-devel] " Chris Lalancette
2009-08-11 10:20       ` [Qemu-devel] [PATCH] Migration via unix sockets Daniel P. Berrange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A8142C3.5020707@redhat.com \
    --to=avi@redhat.com \
    --cc=bonzini@gnu.org \
    --cc=clalance@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).