From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mapb9-0002KE-SO
	for qemu-devel@nongnu.org; Tue, 11 Aug 2009 07:32:59 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mapb5-0002IL-RF
	for qemu-devel@nongnu.org; Tue, 11 Aug 2009 07:32:59 -0400
Received: from [199.232.76.173] (port=55155 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mapb5-0002II-Mn
	for qemu-devel@nongnu.org; Tue, 11 Aug 2009 07:32:55 -0400
Received: from relay2.sgi.com ([192.48.179.30]:46959 helo=relay.sgi.com)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <jes@sgi.com>) id 1Mapb5-0002Tz-DD
	for qemu-devel@nongnu.org; Tue, 11 Aug 2009 07:32:55 -0400
Message-ID: <4A8156D4.2090000@sgi.com>
Date: Tue, 11 Aug 2009 13:32:36 +0200
From: Jes Sorensen <jes@sgi.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] qemu_reserve_isa_irq()
References: <4A7ADE70.7060204@sgi.com> <4A806D86.8090208@codemonkey.ws>
In-Reply-To: <4A806D86.8090208@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, Gleb Natapov <gleb@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>

On 08/10/2009 08:57 PM, Anthony Liguori wrote:
> Jes Sorensen wrote:
>> As part of trying to provide the BIOS with information about PCI
>> interrupt availability, I have added qemu_reserve_isa_irq() to try
>> and keep track of which IRQs are claimed for ISA.
>>
>> If we can agree on this approach, then I'll be using it to pass info
>> on to the guest BIOS in a follow on patch.
>
> Given the new isa qdev support, maybe it would be better to hook into
> isa_connect_irq?

Hi Anthony,

In principle that would be good, the problem is just that the most of
the code still brute force messages with the i8259 array directly,
including the new ISA code. It really needs to be fixed to reference
the ISA IRQ number and not the i8259 array directly :-(

Jes