From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mapjw-0004zP-Sk
	for qemu-devel@nongnu.org; Tue, 11 Aug 2009 07:42:05 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mapjq-0004xs-OA
	for qemu-devel@nongnu.org; Tue, 11 Aug 2009 07:42:03 -0400
Received: from [199.232.76.173] (port=38937 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mapjo-0004xU-R8
	for qemu-devel@nongnu.org; Tue, 11 Aug 2009 07:41:57 -0400
Received: from mx2.redhat.com ([66.187.237.31]:57838)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1Mapjo-00047R-Cp
	for qemu-devel@nongnu.org; Tue, 11 Aug 2009 07:41:56 -0400
Message-ID: <4A815A73.2010200@redhat.com>
Date: Tue, 11 Aug 2009 14:48:03 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <200908102147.n7ALlBHB029958@d03av04.boulder.ibm.com>
In-Reply-To: <200908102147.n7ALlBHB029958@d03av04.boulder.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [Qemu-commits] [COMMIT 0bd8246] vga: do not resize
 the screen on	hw_invalidate
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 08/11/2009 12:48 AM, Anthony Liguori wrote:
> From: Stefano Stabellini<stefano.stabellini@eu.citrix.com>
>
> Hi all,
> currently vga always resizes the screen when vga_hw_invalidate is called
> while this is not required and all the other graphic emulators don't.
> This patch fixes it, making vga invalidate behaviour consistent with the
> other emulated devices.
>
>    

This commit causes qemu to segfault in kvm-autotest:

#0  0x000000000043b3f9 in vga_draw_line24_32 (s1=<value optimized out>, 
d=0x7f57c3096000 <Address 0x7f57c3096000 out of bounds>, 
s=0x7f57c31f6077 "",
     width=<value optimized out>) at 
/home/avi/qemu-kvm/hw/vga_template.h:484
#1  0x000000000043ec7f in vga_draw_graphic (full_update=1) at 
/home/avi/qemu-kvm/hw/vga.c:1767
#2  vga_update_display (opaque=<value optimized out>) at 
/home/avi/qemu-kvm/hw/vga.c:1864
#3  0x00000000004cc202 in vnc_refresh (opaque=0x7f57c31f6077) at vnc.c:2120
#4  0x000000000040a552 in qemu_run_timers () at /home/avi/qemu-kvm/vl.c:1030
#5  main_loop_wait (timeout=<value optimized out>) at 
/home/avi/qemu-kvm/vl.c:4121
#6  0x0000000000421faa in kvm_main_loop () at 
/home/avi/qemu-kvm/qemu-kvm.c:2001
#7  0x000000000040d2c6 in main_loop () at /home/avi/qemu-kvm/vl.c:4291
#8  main (argc=21, argv=0x7ffff181f088, envp=<value optimized out>) at 
/home/avi/qemu-kvm/vl.c:6225

kvm-autotest runs the screendump command repeatedly, perhaps this will 
provide a clue as to the cause.  I've reverted it in qemu-kvm.git.

-- 
error compiling committee.c: too many arguments to function