From: Gerd Hoffmann <kraxel@redhat.com>
To: Jes Sorensen <jes@sgi.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>,
Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu_reserve_isa_irq()
Date: Tue, 11 Aug 2009 16:08:33 +0200 [thread overview]
Message-ID: <4A817B61.2010803@redhat.com> (raw)
In-Reply-To: <4A8156D4.2090000@sgi.com>
On 08/11/09 13:32, Jes Sorensen wrote:
> On 08/10/2009 08:57 PM, Anthony Liguori wrote:
>> Given the new isa qdev support, maybe it would be better to hook into
>> isa_connect_irq?
>
> Hi Anthony,
>
> In principle that would be good, the problem is just that the most of
> the code still brute force messages with the i8259 array directly,
> including the new ISA code. It really needs to be fixed to reference
> the ISA IRQ number and not the i8259 array directly :-(
How about making isa-bus.c own the i8259 array then? We could pass it
to isa_bus_new. Then switch over to reference isa irqs by number. That
allows isa-bus to keep track of the allocations. Maybe it makes sense
to kill the sysbus-style isa_{init,connect}_irq split and have a irq bus
property then.
cheers,
Gerd
next prev parent reply other threads:[~2009-08-11 14:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 13:45 [Qemu-devel] [PATCH] qemu_reserve_isa_irq() Jes Sorensen
2009-08-07 9:13 ` [Qemu-devel] " Gleb Natapov
2009-08-10 18:57 ` [Qemu-devel] " Anthony Liguori
2009-08-11 11:32 ` Jes Sorensen
2009-08-11 14:08 ` Gerd Hoffmann [this message]
2009-08-11 14:45 ` Jes Sorensen
2009-08-11 16:16 ` Gerd Hoffmann
2009-08-11 20:36 ` Gerd Hoffmann
2009-08-12 14:42 ` [Qemu-devel] [PATCH] isa_reserve_irq() Jes Sorensen
2009-08-12 14:58 ` [Qemu-devel] " Gerd Hoffmann
2009-08-12 15:10 ` Jes Sorensen
2009-08-12 15:28 ` Gerd Hoffmann
2009-08-12 15:31 ` Jes Sorensen
2009-08-12 15:41 ` Gerd Hoffmann
2009-08-12 15:41 ` [Qemu-devel] [PATCH] isa_reserve_irq() v4 Jes Sorensen
2009-08-12 15:55 ` [Qemu-devel] " Gerd Hoffmann
2009-08-14 8:55 ` Gerd Hoffmann
2009-08-12 15:18 ` [Qemu-devel] Re: [PATCH] isa_reserve_irq() Jes Sorensen
2009-08-14 8:40 ` [Qemu-devel] [PATCH] qemu_reserve_isa_irq() Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A817B61.2010803@redhat.com \
--to=kraxel@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=gleb@redhat.com \
--cc=jes@sgi.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).