From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Masc0-00046Z-IV for qemu-devel@nongnu.org; Tue, 11 Aug 2009 10:46:04 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Masbv-00045g-Po for qemu-devel@nongnu.org; Tue, 11 Aug 2009 10:46:04 -0400 Received: from [199.232.76.173] (port=50377 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Masbv-00045c-Iy for qemu-devel@nongnu.org; Tue, 11 Aug 2009 10:45:59 -0400 Received: from relay1.sgi.com ([192.48.179.29]:42579 helo=relay.sgi.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Masbu-0006jQ-RN for qemu-devel@nongnu.org; Tue, 11 Aug 2009 10:45:59 -0400 Message-ID: <4A818415.8020706@sgi.com> Date: Tue, 11 Aug 2009 16:45:41 +0200 From: Jes Sorensen MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] qemu_reserve_isa_irq() References: <4A7ADE70.7060204@sgi.com> <4A806D86.8090208@codemonkey.ws> <4A8156D4.2090000@sgi.com> <4A817B61.2010803@redhat.com> In-Reply-To: <4A817B61.2010803@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Anthony Liguori , qemu-devel , Gleb Natapov On 08/11/2009 04:08 PM, Gerd Hoffmann wrote: > On 08/11/09 13:32, Jes Sorensen wrote: >> In principle that would be good, the problem is just that the most of >> the code still brute force messages with the i8259 array directly, >> including the new ISA code. It really needs to be fixed to reference >> the ISA IRQ number and not the i8259 array directly :-( > > How about making isa-bus.c own the i8259 array then? We could pass it to > isa_bus_new. Then switch over to reference isa irqs by number. That > allows isa-bus to keep track of the allocations. Maybe it makes sense to > kill the sysbus-style isa_{init,connect}_irq split and have a irq bus > property then. Hi Gerd, I would like to see that. I was looking into how much it would be, but I got lost in the qdev dependencies :( Cheers, Jes