From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Matj3-0006IW-4m
	for qemu-devel@nongnu.org; Tue, 11 Aug 2009 11:57:25 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Matix-00068b-Le
	for qemu-devel@nongnu.org; Tue, 11 Aug 2009 11:57:24 -0400
Received: from [199.232.76.173] (port=53787 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Matix-00068G-8L
	for qemu-devel@nongnu.org; Tue, 11 Aug 2009 11:57:19 -0400
Received: from mail-gx0-f220.google.com ([209.85.217.220]:53700)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Matiw-0006AP-R2
	for qemu-devel@nongnu.org; Tue, 11 Aug 2009 11:57:18 -0400
Received: by gxk20 with SMTP id 20so11990396gxk.10
	for <qemu-devel@nongnu.org>; Tue, 11 Aug 2009 08:57:18 -0700 (PDT)
Message-ID: <4A8194D9.9040202@codemonkey.ws>
Date: Tue, 11 Aug 2009 10:57:13 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 4/4] qdev: add display capability
References: <1249982427-14481-1-git-send-email-kraxel@redhat.com>
	<1249982427-14481-4-git-send-email-kraxel@redhat.com>
	<4A81755F.3060600@codemonkey.ws> <4A817D73.4020200@redhat.com>
In-Reply-To: <4A817D73.4020200@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Gerd Hoffmann wrote:
> On 08/11/09 15:42, Anthony Liguori wrote:
>> Gerd Hoffmann wrote:
>>> ... and tag devices.
>>
>> Shouldn't there be a direct relationship between a capability and the
>> interfaces the device accepts?
>
> That is the case for some devices only.

A device doesn't have a capability unless it implements the backend 
device interface, no?

That is, a device does not have the Display capability unless it returns 
a DisplayState.

>> That is, instead of explicitly marking something as having a capability
>> of { "ethernet" }, wouldn't you be able to infer that from the present
>> of a VLANClientState property?
>
> Works for ethernet (well, not yet, but most likely some day ...).
>
> What property do you use to identify sound devices?

A QEMUSoundCard * property (r/o).

> What property do you use to identify display devices?

A DisplayState * property (r/o).
> What property do you use to identify watchdog devices?

A WatchdogTimerModel * property (r/o).

Regards,

Anthony Liguori
> cheers,
>   Gerd