From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mau6A-0001XY-Bx for qemu-devel@nongnu.org; Tue, 11 Aug 2009 12:21:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mau65-0001TA-Ph for qemu-devel@nongnu.org; Tue, 11 Aug 2009 12:21:18 -0400 Received: from [199.232.76.173] (port=34835 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mau65-0001Ss-Bu for qemu-devel@nongnu.org; Tue, 11 Aug 2009 12:21:13 -0400 Received: from mx2.redhat.com ([66.187.237.31]:55774) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mau64-0002wy-Ut for qemu-devel@nongnu.org; Tue, 11 Aug 2009 12:21:13 -0400 Message-ID: <4A819BE9.1050108@redhat.com> Date: Tue, 11 Aug 2009 19:27:21 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] make vga screen_dump use DisplayState properly References: <4A81917C.3070706@codemonkey.ws> In-Reply-To: <4A81917C.3070706@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Stefano Stabellini On 08/11/2009 06:42 PM, Anthony Liguori wrote: > Stefano Stabellini wrote: >> Hi all, >> currently the vga screen_dump code doesn't use the DisplayState >> interface properly and tries to replace it temporarily while taking the >> screenshot. >> A better approach is to register a DisplayChangeListener, call >> vga_hw_update, and finally write the ppm in the next call from >> dpy_update. >> >> Testing is appreciated. > > Does this fix kvm-autotest Avi? It does. Stefano, thanks for the quick response. -- error compiling committee.c: too many arguments to function