Re: [Qemu-devel] [PATCH 4/4] qdev: add display capability

[Gerd Hoffmann <kraxel@redhat.com>]

On 08/11/09 17:57, Anthony Liguori wrote:
> Gerd Hoffmann wrote:
>> That is the case for some devices only.
>
> A device doesn't have a capability unless it implements the backend
> device interface, no?

Right.  Although that doesn't imply there is a property needed for that.

>> What property do you use to identify display devices?
>
> A DisplayState * property (r/o).

Ok, that is the backend side of display devices.  It would somehow make 
sense to export that as property like we do today for DriveInfo and 
CharDriverState, although there is no need right now to have that 
accessable as property.


>> What property do you use to identify sound devices?
>
> A QEMUSoundCard * property (r/o).

That is a linked list of all sound card device instances.

>> What property do you use to identify watchdog devices?
>
> A WatchdogTimerModel * property (r/o).

That is a linked list of all watchdog device models.

Why on earth these should become device properties?
That doesn't make sense to me at all.

Oh, and the WatchdogTimerModel is the one I actually want to kill off 
some day (after converting watchdogs to qdev).  There is no need for a 
private device model list, we can use the qdev list instead and filter 
for DeviceInfo->caps & DEV_CAP_WATCHDOG.

cheers,
   Gerd