From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MbECq-00014y-49
	for qemu-devel@nongnu.org; Wed, 12 Aug 2009 09:49:32 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MbECl-00013Y-87
	for qemu-devel@nongnu.org; Wed, 12 Aug 2009 09:49:31 -0400
Received: from [199.232.76.173] (port=33186 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MbECl-00013K-4U
	for qemu-devel@nongnu.org; Wed, 12 Aug 2009 09:49:27 -0400
Received: from mx2.redhat.com ([66.187.237.31]:45868)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kwolf@redhat.com>) id 1MbECj-0004jW-6C
	for qemu-devel@nongnu.org; Wed, 12 Aug 2009 09:49:25 -0400
Message-ID: <4A82C81F.3000401@redhat.com>
Date: Wed, 12 Aug 2009 15:48:15 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Add support for vmware vmdk scsi images
	to qemu-img
References: <1248969319-8704-1-git-send-email-pktoss@gmail.com>
	<4A71EB4E.3070904@codemonkey.ws>
In-Reply-To: <4A71EB4E.3070904@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Pantelis Koukousoulas <pktoss@gmail.com>, qemu-devel@nongnu.org

Anthony Liguori schrieb:
> Pantelis Koukousoulas wrote:
>> diff --git a/block_int.h b/block_int.h
>> index 830b7e9..0311198 100644
>> --- a/block_int.h
>> +++ b/block_int.h
>> @@ -30,10 +30,12 @@
>>  #define BLOCK_FLAG_ENCRYPT	1
>>  #define BLOCK_FLAG_COMPRESS	2
>>  #define BLOCK_FLAG_COMPAT6	4
>> +#define BLOCK_FLAG_SCSI         8
> 
> The flag space is limited and I don't want to pollute it with options 
> that are of no use to QEMU.  If you were able to limit the impact of 
> this patch to just block/vmdk.c, we would be more likely to consider 
> it.  That may require a greater refactoring of how options work though.

Well, yes, a refactoring as great as using a local int scsi instead of
defining a global constant to be or-ed into a local int flags... ;-)
Actually I think we could drop these global BLOCK_FLAG_* completely
without losing anything.

And otherwise the patch already is completely local to VMDK.

Kevin