From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MbFTg-00045C-Up
	for qemu-devel@nongnu.org; Wed, 12 Aug 2009 11:11:00 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MbFTc-00042w-A0
	for qemu-devel@nongnu.org; Wed, 12 Aug 2009 11:11:00 -0400
Received: from [199.232.76.173] (port=47824 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MbFTc-00042i-3T
	for qemu-devel@nongnu.org; Wed, 12 Aug 2009 11:10:56 -0400
Received: from relay2.sgi.com ([192.48.179.30]:51562 helo=relay.sgi.com)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <jes@sgi.com>) id 1MbFTb-00066i-Qw
	for qemu-devel@nongnu.org; Wed, 12 Aug 2009 11:10:55 -0400
Message-ID: <4A82DB7C.6090906@sgi.com>
Date: Wed, 12 Aug 2009 17:10:52 +0200
From: Jes Sorensen <jes@sgi.com>
MIME-Version: 1.0
References: <4A7ADE70.7060204@sgi.com> <4A806D86.8090208@codemonkey.ws>
	<4A8156D4.2090000@sgi.com> <4A817B61.2010803@redhat.com>
	<4A818415.8020706@sgi.com> <4A81D666.2010404@redhat.com>
	<4A82D4E4.90200@sgi.com> <4A82D8B1.7000402@redhat.com>
In-Reply-To: <4A82D8B1.7000402@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] isa_reserve_irq()
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, Gleb Natapov <gleb@redhat.com>

On 08/12/2009 04:58 PM, Gerd Hoffmann wrote:
> On 08/12/09 16:42, Jes Sorensen wrote:
>> Hi Gerd,
>>
>> This looks great! I have implemented isa_reserve_irq() on top of this.
>> It allows one to reserve ISA irqs without converting them to qdev, which
>> for certain interrupts makes sense,
>
> which ones?

ferr

>> and I have also made the other users
>> call it until they are converted to qdev.
>
> I think that deserves a comment clearly stating that this interface is a
> (temporary?) thing for not-yet converted devices.
>
> Otherwise it looks fine to me.

If you think it makes sense to convert ferr as well, then I'll be happy
to add the comment.

Anthony also pointed out that hpet shouldn't be on the list - it makes
sense. The BIOS can filter out irq2 based on the irq0override flag, so I
will take out the hpet bits too.

Cheers,
Jes